AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 41 Bitcoin

Merge pull request #752 from Foundation-Devices/sft-8674-passport-core-signing-flow-does-not-show-a-non

Public commit record

What the developer wrote

Authored by mjg-foundation

73/100 · Adequate
Merge pull request #752 from Foundation-Devices/sft-8674-passport-core-signing-flow-does-not-show-a-non

SFT-8674: warn about timelocks when reviewing a transaction
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds on-screen warnings to the Passport hardware wallet when a user is reviewing a Bitcoin transaction that contains timelocks. Timelocks can prevent a transaction from confirming until a future date or until certain inputs have aged, which could be used to trick someone into signing a payment that cannot actually be spent right away. The change does not alter transaction validation rules; it only makes existing timelock behavior visible to the user during signing.

Recommended action

No immediate action required. This is a defensive UX improvement. Users should ensure firmware is updated so that timelock warnings are shown during transaction review. Developers may want to confirm that the warning text is localized and that the custom UTC formatter correctly handles leap years and edge timestamps.

Security signals we found

01

UI warning for absolute time-based nLockTime

02

UI warning for BIP68 relative timelocks on version-2 transactions

03

Height-based nLockTime intentionally not flagged to avoid false positives

04

No consensus or validation rule changes; purely informational

05

Adds unit and host test coverage for the new warnings

Risk score

Why this scored 41/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.