AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 24 Bitcoin

Add native Unchained wallet connection

Public commit record

What the developer wrote

Authored by Jack

45/100 · Thin
Add native Unchained wallet connection
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds support for connecting the Passport hardware wallet to the Unchained multisig service. It introduces a new way to pass already-encoded data into the QR/UR encoder, plus a new wallet definition and CBOR encoding helper. The changes are mostly additive feature code; there is no vendor statement that this fixes a security bug, and no independent security disclosure is referenced.

Recommended action

Treat as a feature commit, not an emergency security patch. Review the raw UR encoder for memory-safety edge cases: confirm `ur_type_len` and `message_len` cannot exceed the static buffer capacities, ensure the type-string validator cannot be bypassed via UTF-8 multibyte sequences, and fuzz `ur_encoder_start_raw` with malformed inputs. Verify that `create_unchained_hdkey_cbor` cannot produce oversized CBOR and that the BIP45 derivation path is correct for Unchained.

Security signals we found

01

New unsafe FFI function `ur_encoder_start_raw` takes raw pointers and lengths from MicroPython

02

Static mutable buffer `UR_ENCODER_TYPE` added in SRAM section, filled from user-supplied type string

03

CBOR payload is copied into `UR_ENCODER_MESSAGE` without semantic validation

04

Type-string validation rejects uppercase and special characters but does not bound-check against UR_MAX_TYPE beyond a length comparison

05

New wallet export derives `m/45'` and packages public key + chain code as a UR; private key material is not exposed

06

No vendor security disclosure or CVE referenced in commit message or changelog

Risk score

Why this scored 24/100

Our methodology →
Potential impact 3/30
Exploitability 4/25
Stealth signal 3/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.