pytest: fix flake in reckless install timeout.
What the developer wrote
Authored by Rusty Russell
pytest: fix flake in reckless install timeout.
Don't test installing a plugin under valgrind. There's no way to
increase reckless' (completely reasonable) 15 seconds timeout, and that
can happen under valgrind & CI:
```
def test_reckless_uv_install(node_factory):
node = get_reckless_node(node_factory)
node.start()
r = reckless([f"--network={NETWORK}", "-v", "install", "testpluguv"],
dir=node.lightning_dir)
> assert r.returncode == 0
E assert 1 == 0
E + where 1 = self.returncode, self.stdout, self.stderr.returncode
tests/test_reckless.py:359: AssertionError
...
***RECKLESS STDERR***
config file not found: /tmp/ltests-tui1vmrg/test_reckless_uv_install_1/lightning-1/regtest/config
press [Y] to create one now.
config file not found: /tmp/ltests-tui1vmrg/test_reckless_uv_install_1/lightning-1/reckless/regtest-reckless.conf
config file not found: /tmp/ltests-tui1vmrg/test_reckless_uv_install_1/lightning-1/reckless/.sources
Traceback (most recent call last):
File "/home/runner/work/lightning/lightning/tools/reckless", line 2091, in <module>
log.add_result(args.func(target))
File "/home/runner/work/lightning/lightning/tools/reckless", line 1524, in install
return _enable_installed(installed, plugin_name)
File "/home/runner/work/lightning/lightning/tools/reckless", line 1476, in _enable_installed
if enable(installed.name):
File "/home/runner/work/lightning/lightning/tools/reckless", line 1647, in enable
lightning_cli('plugin', 'start', path)
File "/home/runner/work/lightning/lightning/tools/reckless", line 1613, in lightning_cli
clncli = run(cmd, stdout=PIPE, stderr=PIPE, check=False, timeout=timeout)
File "/opt/hostedtoolcache/Python/3.10.18/x64/lib/python3.10/subprocess.py", line 505, in run
stdout, stderr = process.communicate(input, timeout=timeout)
File "/opt/hostedtoolcache/Python/3.10.18/x64/lib/python3.10/subprocess.py", line 1154, in communicate
stdout, stderr = self._communicate(input, endtime, timeout)
File "/opt/hostedtoolcache/Python/3.10.18/x64/lib/python3.10/subprocess.py", line 2022, in _communicate
self._check_timeout(endtime, orig_timeout, stdout, stderr)
File "/opt/hostedtoolcache/Python/3.10.18/x64/lib/python3.10/subprocess.py", line 1198, in _check_timeout
raise TimeoutExpired(
subprocess.TimeoutExpired: Command '['/home/runner/work/lightning/lightning/cli/lightning-cli', '--network=regtest', '--lightning-dir=/tmp/ltests-tui1vmrg/test_reckless_uv_install_1/lightning-1', 'plugin', 'start', '/tmp/ltests-tui1vmrg/test_reckless_uv_install_1/lightning-1/reckless/testpluguv/testpluguv.py']' timed out after 15 seconds
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit is a test-only change. It skips one pytest test when the code is being run under Valgrind on a slow machine, because the test's 15-second timeout was sometimes exceeded in CI. There is no security issue in the actual Core Lightning software.
No security action needed. This is a CI/test flakiness fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds a @unittest.skipIf(VALGRIND and SLOW_MACHINE, ...) decorator to test_reckless_uv_install in tests/test_reckless.py. The test installs a plugin via the reckless tool and then starts it with lightning-cli plugin start. Under Valgrind on slow CI runners, lightning-cli can take longer than reckless’s hard-coded 15-second timeout, causing a flaky failure. The fix simply avoids running this timing-sensitive test in that configuration. No product code is changed.
Changed components
tests/test_reckless.pyInspect captured patch +2 / −1
diff --git a/tests/test_reckless.py b/tests/test_reckless.py
index 64efa6ab..10ade362 100644
--- a/tests/test_reckless.py
+++ b/tests/test_reckless.py
@@ -2,7 +2,7 @@ from fixtures import * # noqa: F401,F403
import subprocess
from pathlib import PosixPath, Path
import socket
-from pyln.testing.utils import VALGRIND
+from pyln.testing.utils import VALGRIND, SLOW_MACHINE
import pytest
import os
import re
@@ -351,6 +351,7 @@ def test_tag_install(node_factory):
header = line
+@unittest.skipIf(VALGRIND and SLOW_MACHINE, "node too slow for starting plugin under valgrind")
def test_reckless_uv_install(node_factory):
node = get_reckless_node(node_factory)
node.start()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.