pyln-client: update ancient gossmap in test_gossmap tests.
What the developer wrote
Authored by Rusty Russell
pyln-client: update ancient gossmap in test_gossmap tests.
It was still using private channel announcements, which were removed
in v13.
What changed, and why it matters
This commit updates a test fixture and its matching test data in the pyln-client test suite. The old gossip store file used an outdated network message format (private channel announcements) that was removed in Core Lightning v13, so the test was failing. The change replaces the binary fixture with a freshly generated one and updates the expected channel ID and timestamps in the test code. There is no security fix here—this is purely a maintenance update to keep tests passing after a protocol cleanup.
No security action required. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies contrib/pyln-client/tests/data/gossip_store.simple.xz (a binary gossip_store snapshot) and contrib/pyln-client/tests/test_gossmap.py. The Python test previously expected channel short ID 103x1x1 and timestamps 1631005020; the new fixture uses short ID 103x1x0 and timestamps 1759208366. The commit message explains the old fixture relied on private channel announcements, which were removed in v13. No runtime code, no parsing/validation logic, and no security boundary are changed.
Changed components
contrib/pyln-client/tests/data/gossip_store.simple.xzcontrib/pyln-client/tests/test_gossmap.pyInspect captured patch +5 / −5
diff --git a/contrib/pyln-client/tests/data/gossip_store.simple.xz b/contrib/pyln-client/tests/data/gossip_store.simple.xz
index 23981fad..2b4a3baa 100644
Binary files a/contrib/pyln-client/tests/data/gossip_store.simple.xz and b/contrib/pyln-client/tests/data/gossip_store.simple.xz differ
diff --git a/contrib/pyln-client/tests/test_gossmap.py b/contrib/pyln-client/tests/test_gossmap.py
index 3c93302d..dbb15fd7 100644
--- a/contrib/pyln-client/tests/test_gossmap.py
+++ b/contrib/pyln-client/tests/test_gossmap.py
@@ -50,7 +50,7 @@ def test_gossmap(tmp_path):
def test_gossmap_halfchannel(tmp_path):
- """ this test a simple [l1->l2] gossip store that was created by the pyln-testing framework """
+ """ this test a simple [l1->l2] gossip store that was created by the pyln-testing framework (tests/test_gossip.py::test_announce_address) """
sfile = unxz_data_tmp("gossip_store.simple.xz", tmp_path, "gossip_store", "xb")
g = Gossmap(sfile)
@@ -64,13 +64,13 @@ def test_gossmap_halfchannel(tmp_path):
assert n1
assert n2
- chan = g.get_channel("103x1x1")
+ chan = g.get_channel("103x1x0")
assert chan
assert chan.node1 == n1
assert chan.node2 == n2
half0 = chan.get_direction(0)
- half1 = g.get_halfchannel("103x1x1", 1)
+ half1 = g.get_halfchannel("103x1x0", 1)
assert half0
assert half1
assert half0.direction == 0
@@ -83,8 +83,8 @@ def test_gossmap_halfchannel(tmp_path):
assert half1.destination == n1
# check metadata
- assert half0.timestamp == 1631005020
- assert half1.timestamp == 1631005020
+ assert half0.timestamp == 1759208366
+ assert half1.timestamp == 1759208366
assert half0.cltv_expiry_delta == 6
assert half1.cltv_expiry_delta == 6
assert half0.htlc_minimum_msat == 0
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.