AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 21 Bitcoin

plugins: move listpays from pay plugin to xpay plugin.

Public commit record

What the developer wrote

Authored by Rusty Russell

73/100 · Adequate
plugins: move listpays from pay plugin to xpay plugin.

This will make life easier when we remove the pay plugin, but also fixes
an issue where `listpays` can indicate ongoing payments are failed,
even though xpay is still working on it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This change moves the `listpays` command from the older `pay` plugin to the newer `xpay` plugin. The practical effect is that when you ask your node to list recent payments, it now checks whether `xpay` is still retrying a payment before marking it as failed. Previously, `listpays` could wrongly report an ongoing payment as failed because it only looked at the old `pay` plugin's state. There is no new attack or remote exploit here; it is a bug-fix/refactor that improves reporting accuracy.

Recommended action

No urgent security action is required. Operators and integrators should be aware that `listpays` is now provided by the `xpay` plugin, so any plugin-loading or RPC-routing configuration that assumed `listpays` came from `pay` may need review. Consider updating release notes to document the move and the corrected status reporting.

Security signals we found

01

Bug fix: listpays could incorrectly report ongoing xpay payments as failed

02

Code move/refactor of listpays implementation from pay plugin to xpay plugin

03

Test annotations removed because behavior is now correct

04

No new input parsing, network handling, or cryptographic code added

Risk score

Why this scored 21/100

Our methodology →
Potential impact 4/30
Exploitability 0/25
Stealth signal 2/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.