chore: Ensure the logging library does not get upset when output capture is disabled.
What the developer wrote
Authored by Christian Decker
chore: Ensure the logging library does not get upset when output capture is disabled.
Changelog-Fixed: Testing infrastructure no longer fails when logging output capture is disabled.
What changed, and why it matters
This commit only changes how the project's automated testing and build scripts set an environment variable (TEST_LOG_IGNORE_ERRORS=1). It tells the test logging library not to treat certain log-related issues as fatal during test runs. There is no change to the Core Lightning node software, wallet handling, network protocol, cryptography, or any code that runs in production. It is purely a testing-infrastructure convenience fix.
No security action needed. Treat as a normal testing-infrastructure maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds TEST_LOG_IGNORE_ERRORS=1 to GitHub Actions workflow files (ci.yaml, coverage-nightly.yaml), the Makefile’s pytest invocation, and several Taskfile.yml test tasks. The variable name and the commit message indicate it suppresses errors from the logging library when pytest output capture is disabled. No runtime source files are modified, and no product security boundary is affected.
Changed components
CI/test configuration only: .github/workflows/ci.yaml.github/workflows/coverage-nightly.yamlMakefileTaskfile.ymlInspect captured patch +8 / −1
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index f0b531c8..28557a95 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -17,6 +17,7 @@ env:
SLOW_MACHINE: 1
CI_SERVER_URL: "http://35.239.136.52:3170"
PYTEST_OPTS_BASE: "-vvv --junit-xml=report.xml --timeout=1800 --durations=10"
+ TEST_LOG_IGNORE_ERRORS: "1"
jobs:
prebuild:
diff --git a/.github/workflows/coverage-nightly.yaml b/.github/workflows/coverage-nightly.yaml
index dfa89686..cbf04b2f 100644
--- a/.github/workflows/coverage-nightly.yaml
+++ b/.github/workflows/coverage-nightly.yaml
@@ -91,6 +91,7 @@ jobs:
PYTEST_PAR: ${{ matrix.pytest_par }}
SLOW_MACHINE: 1
TIMEOUT: 900
+ TEST_LOG_IGNORE_ERRORS: "1"
run: |
mkdir -p "$CLN_COVERAGE_DIR"
uv run eatmydata pytest tests/ -n ${PYTEST_PAR} -vvv
diff --git a/Makefile b/Makefile
index 6576f693..5b5f33b7 100644
--- a/Makefile
+++ b/Makefile
@@ -518,7 +518,7 @@ ifeq ($(PYTEST),)
exit 1
else
# Explicitly hand VALGRIND so you can override on make cmd line.
- PYTHONPATH=$(MY_CHECK_PYTHONPATH) TEST_DEBUG=1 VALGRIND=$(VALGRIND) uv run $(PYTEST) $(PYTEST_TESTS) $(PYTEST_OPTS)
+ PYTHONPATH=$(MY_CHECK_PYTHONPATH) TEST_DEBUG=1 TEST_LOG_IGNORE_ERRORS=1 VALGRIND=$(VALGRIND) uv run $(PYTEST) $(PYTEST_TESTS) $(PYTEST_OPTS)
endif
check-fuzz: $(ALL_FUZZ_TARGETS)
diff --git a/Taskfile.yml b/Taskfile.yml
index 0daf83fb..4c0c8fb7 100644
--- a/Taskfile.yml
+++ b/Taskfile.yml
@@ -12,12 +12,15 @@ tasks:
dir: '.'
deps:
- build
+ env:
+ TEST_LOG_IGNORE_ERRORS: "1"
cmds:
- uv run pytest --force-flaky -vvv -n {{ .PYTEST_PAR }} tests {{ .CLI_ARGS }}
test-liquid:
env:
TEST_NETWORK: "liquid-regtest"
+ TEST_LOG_IGNORE_ERRORS: "1"
cmds:
- sed -i 's/TEST_NETWORK=regtest/TEST_NETWORK=liquid-regtest/g' config.vars
- uv run make cln-grpc/proto/node.proto
@@ -62,6 +65,8 @@ tasks:
deps:
- in-docker-init
- in-docker-build-deps
+ env:
+ TEST_LOG_IGNORE_ERRORS: "1"
cmds:
# This way of copying allows us to copy the dirty tree, without
# triggering any of the potentially configured hooks which might
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.