pytest: note that we also trigger CI failure on this "That's weird" messages.
What the developer wrote
Authored by Rusty Russell
pytest: note that we also trigger CI failure on this "That's weird" messages.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This is a one-line change to a test helper that updates an error message shown when automated tests fail. It does not change any production code, network behavior, or security logic. The commit simply notes that the test suite already treats "That's weird" log messages the same as "BROKEN" log messages when deciding whether a test failed.
No security action needed. This is a test-only string change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies contrib/pyln-testing/pyln/testing/fixtures.py, a pytest fixture used only in testing. The function map_node_error is called with checkBroken as the predicate and a human-readable description string. The description is changed from “had BROKEN messages” to “had BROKEN or That’s weird messages”. The predicate itself is unchanged, so the behavior was already in place; only the failure label is made more accurate.
Changed components
contrib/pyln-testing/pyln/testing/fixtures.pyInspect captured patch +1 / −1
diff --git a/contrib/pyln-testing/pyln/testing/fixtures.py b/contrib/pyln-testing/pyln/testing/fixtures.py
index db4206a1..ef55ecd0 100644
--- a/contrib/pyln-testing/pyln/testing/fixtures.py
+++ b/contrib/pyln-testing/pyln/testing/fixtures.py
@@ -498,7 +498,7 @@ def node_factory(request, directory, test_name, bitcoind, executor, db_provider,
map_node_error(nf.nodes, printValgrindErrors, "reported valgrind errors")
map_node_error(nf.nodes, printCrashLog, "had crash.log files")
- map_node_error(nf.nodes, checkBroken, "had BROKEN messages")
+ map_node_error(nf.nodes, checkBroken, "had BROKEN or That's weird messages")
map_node_error(nf.nodes, lambda n: not n.allow_warning and n.daemon.is_in_log(r' WARNING:'), "had warning messages")
map_node_error(nf.nodes, checkReconnect, "had unexpected reconnections")
map_node_error(nf.nodes, checkPluginJSON, "had malformed hooks/notifications")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.