askrene: relax timeout for reservation leak
What the developer wrote
Authored by Lagrang3
askrene: relax timeout for reservation leak
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
What changed, and why it matters
This commit only changes a test file, increasing a timeout in an existing test by ten times. It does not modify any production code. There is no direct security fix or vulnerability being patched here; it appears to be a test reliability tweak to prevent flaky failures under slow or loaded test conditions.
No security action required. Treat as a routine test maintenance change. If investigating the underlying reservation leak behavior, review the askrene production code separately rather than this test-only commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/test_askrene.py, changing the as_completed timeout from TIMEOUT to TIMEOUT * 10 in test_reservations_leak_under_load. The test checks that askrene reservations do not leak under concurrent payment load. The longer timeout only gives the test more time to finish; it does not alter Core Lightning’s reservation logic, memory handling, or any network-facing behavior.
Changed components
tests/test_askrene.pyInspect captured patch +2 / −1
diff --git a/tests/test_askrene.py b/tests/test_askrene.py
index 5e8f0512..1a655bbf 100644
--- a/tests/test_askrene.py
+++ b/tests/test_askrene.py
@@ -1992,9 +1992,10 @@ def test_reservations_leak_under_load(node_factory, executor):
res = l1.rpc.askrene_listreservations()["reservations"]
scids = [r["short_channel_id_dir"] for r in res]
return len(scids) != len(set(scids))
+
wait_for(has_channel_contention)
- for f in concurrent_futures.as_completed(futs, timeout=TIMEOUT):
+ for f in concurrent_futures.as_completed(futs, timeout=TIMEOUT * 10):
f.result() # raise on any payment failure
assert l1.rpc.askrene_listreservations() == {"reservations": []}
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.