plugins: make fatal errors neater.
What the developer wrote
Authored by Rusty Russell
plugins: make fatal errors neater.
Without this they get run together on stderr.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This is a trivial formatting fix. When a plugin crashes with a fatal error, the message printed to the terminal was missing a final newline, so multiple error messages could appear squashed together. The change adds that missing newline. It has no security relevance.
No security action needed. Treat as a normal code-quality fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In plugins/libplugin.c, the NORETURN plugin_errv() function logs a fatal error and also prints it to stderr. The existing code called vfprintf(stderr, fmt, ap2) but never emitted a trailing newline, causing stderr output to run together. The patch adds fprintf(stderr, “\n”); before plugin_exit(). This is purely a cosmetic/usability improvement.
Changed components
plugins/libplugin.cplugin_errv() stderr formattingInspect captured patch +1 / −0
diff --git a/plugins/libplugin.c b/plugins/libplugin.c
index 3d357008..5b5c2f4e 100644
--- a/plugins/libplugin.c
+++ b/plugins/libplugin.c
@@ -1995,6 +1995,7 @@ void NORETURN plugin_errv(struct plugin *p, const char *fmt, va_list ap)
plugin_logv(p, LOG_BROKEN, fmt, ap);
vfprintf(stderr, fmt, ap2);
+ fprintf(stderr, "\n");
plugin_exit(p, 1);
va_end(ap2);
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.