Public commit record
70/100 · Adequate
What the developer wrote
Authored by Rusty Russell
tests/fuzz: fix include order.
Nobody ever runs `make check-includes` with fuzzing enabled.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
What changed, and why it matters
This commit only reorders #include lines in fuzz-test source files and adds minor indentation to two direct .c file includes. It is a coding-style/build-hygiene fix with no functional code changes and no security relevance.
Recommended action
No security action needed. Treat as normal build-hygiene/style cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff shows purely cosmetic include-order adjustments across seven fuzzer test files so they pass make check-includes when fuzzing is enabled. No logic, data structures, APIs, or runtime behavior is altered. Two files also gain leading whitespace on an #include ".../something.c" line, which is still a preprocessor include and has no semantic effect.
Changed components
tests/fuzz/fuzz-addr.ctests/fuzz/fuzz-bech32.ctests/fuzz/fuzz-bolt12-bech32-decode.ctests/fuzz/fuzz-codex32.ctests/fuzz/fuzz-error-warning.ctests/fuzz/fuzz-funder-policy.ctests/fuzz/fuzz-hmac-sha256.cInspect captured patch +12 / −12
diff --git a/tests/fuzz/fuzz-addr.c b/tests/fuzz/fuzz-addr.c
index be933c0..082c549 100644
--- a/tests/fuzz/fuzz-addr.c
+++ b/tests/fuzz/fuzz-addr.c
@@ -1,9 +1,9 @@
#include "config.h"
+#include <assert.h>
#include <common/addr.h>
#include <common/setup.h>
#include <common/utils.h>
-#include <assert.h>
#include <tests/fuzz/libfuzz.h>
void init(int *argc, char ***argv)
diff --git a/tests/fuzz/fuzz-bech32.c b/tests/fuzz/fuzz-bech32.c
index 9e92ef7..ae686bf 100644
--- a/tests/fuzz/fuzz-bech32.c
+++ b/tests/fuzz/fuzz-bech32.c
@@ -1,7 +1,7 @@
#include "config.h"
#include <assert.h>
-#include <common/utils.h>
#include <common/bech32.h>
+#include <common/utils.h>
#include <stdint.h>
#include <string.h>
#include <tests/fuzz/libfuzz.h>
diff --git a/tests/fuzz/fuzz-bolt12-bech32-decode.c b/tests/fuzz/fuzz-bolt12-bech32-decode.c
index eeef0a3..bd3d867 100644
--- a/tests/fuzz/fuzz-bolt12-bech32-decode.c
+++ b/tests/fuzz/fuzz-bolt12-bech32-decode.c
@@ -6,7 +6,7 @@
#include <tests/fuzz/libfuzz.h>
/* Include bolt12.c directly, to gain access to string_to_data(). */
-#include "../../common/bolt12.c"
+ #include "../../common/bolt12.c"
void init(int *argc, char ***argv) { common_setup("fuzzer"); }
diff --git a/tests/fuzz/fuzz-codex32.c b/tests/fuzz/fuzz-codex32.c
index 20baaf4..87e2324 100644
--- a/tests/fuzz/fuzz-codex32.c
+++ b/tests/fuzz/fuzz-codex32.c
@@ -2,10 +2,10 @@
#include <assert.h>
#include <ccan/ccan/array_size/array_size.h>
#include <ccan/ccan/tal/str/str.h>
-#include <common/setup.h>
#include <common/bech32.h>
-#include <common/utils.h>
#include <common/codex32.h>
+#include <common/setup.h>
+#include <common/utils.h>
#include <tests/fuzz/libfuzz.h>
/* Default mutator defined by libFuzzer */
diff --git a/tests/fuzz/fuzz-error-warning.c b/tests/fuzz/fuzz-error-warning.c
index b28c70b..da6631b 100644
--- a/tests/fuzz/fuzz-error-warning.c
+++ b/tests/fuzz/fuzz-error-warning.c
@@ -1,12 +1,12 @@
#include "config.h"
-#include <stdio.h>
-#include <fcntl.h>
-#include <setjmp.h>
-#include <common/per_peer_state.h>
#include <common/peer_failed.h>
+#include <common/per_peer_state.h>
#include <common/read_peer_msg.h>
#include <common/status.h>
#include <common/utils.h>
+#include <fcntl.h>
+#include <setjmp.h>
+#include <stdio.h>
#include <tests/fuzz/libfuzz.h>
static jmp_buf exit_jmp;
diff --git a/tests/fuzz/fuzz-funder-policy.c b/tests/fuzz/fuzz-funder-policy.c
index c3a42c5..25667fb 100644
--- a/tests/fuzz/fuzz-funder-policy.c
+++ b/tests/fuzz/fuzz-funder-policy.c
@@ -1,11 +1,11 @@
#include "config.h"
#include <ccan/array_size/array_size.h>
#include <common/setup.h>
-#include <wire/wire.h>
#include <stdio.h>
#include <tests/fuzz/libfuzz.h>
+#include <wire/wire.h>
-#include "../../plugins/funder_policy.c"
+ #include "../../plugins/funder_policy.c"
/* AUTOGENERATED MOCKS START */
/* Generated stub for json_add_string */
diff --git a/tests/fuzz/fuzz-hmac-sha256.c b/tests/fuzz/fuzz-hmac-sha256.c
index 20be746..0daa312 100644
--- a/tests/fuzz/fuzz-hmac-sha256.c
+++ b/tests/fuzz/fuzz-hmac-sha256.c
@@ -5,8 +5,8 @@
#include <assert.h>
#include <ccan/crypto/hmac_sha256/hmac_sha256.h>
#include <ccan/mem/mem.h>
-#include <openssl/hmac.h>
#include <openssl/evp.h>
+#include <openssl/hmac.h>
#include <openssl/sha.h>
#include <tests/fuzz/libfuzz.h>
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.