pytest: fix changed msg on plugin failure.
What the developer wrote
Authored by Rusty Russell
pytest: fix changed msg on plugin failure.
bc4bb2b0ef7261a82cb6ff84e635dadf4f283e89 "libplugin: use jsonrpc_io logic for sync requests too."
changed this message, and test was not updated.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit only updates a single test's expected error message string to match a wording change introduced by an earlier code change. It is a test-only fix with no security relevance.
No security action needed; this is a routine test maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/test_plugin.py, changing the broken_log regex in test_important_plugin from ‘Reading JSON input: Connection reset by peer’ to ‘Reading sync lightningd: Connection reset by peer’. This aligns the test with a prior libplugin change (bc4bb2b0ef7261a82cb6ff84e635dadf4f283e89) that switched sync requests to use jsonrpc_io logic, which altered the logged message. No production code is changed.
Changed components
tests/test_plugin.pyInspect captured patch +1 / −1
diff --git a/tests/test_plugin.py b/tests/test_plugin.py
index 0989e89c..c6fe4dc2 100644
--- a/tests/test_plugin.py
+++ b/tests/test_plugin.py
@@ -2315,7 +2315,7 @@ def test_important_plugin(node_factory):
n = node_factory.get_node(options={"important-plugin": os.path.join(pluginsdir, "nonexistent")},
may_fail=True, expect_fail=True,
# Other plugins can complain as lightningd stops suddenly:
- broken_log='Plugin marked as important, shutting down lightningd|Reading JSON input: Connection reset by peer|Lost connection to the RPC socket',
+ broken_log='Plugin marked as important, shutting down lightningd|Reading sync lightningd: Connection reset by peer|Lost connection to the RPC socket',
start=False)
n.daemon.start(wait_for_initialized=False, stderr_redir=True)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.