AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 30 Bitcoin

wallet: let wallet_inflight_save update i_sent_sigs

Public commit record

What the developer wrote

Authored by Sangbida Chaudhuri

73/100 · Adequate
wallet: let wallet_inflight_save update i_sent_sigs

Turns out we never persisted this flag after the fact.
We're about to start relying on it, so save it properly.

Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit 7a01495359add9c1f1160440fee5335c4a5608f1)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a bug where a flag called i_sent_sigs was not being saved to the database when updating a channel funding inflight. The flag tracks whether a node has already sent signatures for a funding transaction. Because the flag was not persisted, a node could forget it had sent signatures after a restart, which could lead to incorrect behavior in upcoming code that relies on this flag. The fix is a one-line SQL update change to also write the i_sent_sigs column.

Recommended action

Treat as a low-to-moderate correctness fix. Review the upcoming code that relies on i_sent_sigs to confirm whether the unpersisted flag could have led to a security-relevant failure (e.g., signature replay, channel state inconsistency, or fund loss). Backport if the dependent code is already in release branches. No immediate emergency response is indicated by the diff alone.

Security signals we found

01

State-persistence bug in a Bitcoin/Lightning funding workflow

02

Flag controls whether signatures for a channel funding transaction were already sent

03

Incorrect flag after restart could cause double-send, missed send, or protocol desynchronization

04

Fix is small and targeted, but commit message implies future logic depends on it

Risk score

Why this scored 30/100

Our methodology →
Potential impact 8/30
Exploitability 4/25
Stealth signal 6/15
Affected reach 5/15
Confidence 5/10
Evidence quality 2/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.