CI: make downgrade and slow integration tests depend on check-compiled-source step.
What the developer wrote
Authored by Rusty Russell
CI: make downgrade and slow integration tests depend on check-compiled-source step.
As pointed out by Alex Myers: we don't want to waste time running the
complex steps if the generated files are not up-to-date.
But we still run the faster "integration" tests (not valgrind or
sanitizer ones), since they often reveal early failures.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit changes the GitHub Actions CI workflow so that three slower, more complex test jobs now wait for a 'check-compiled-source' step instead of the plain 'compile' step. It is purely a build-pipeline efficiency tweak to avoid wasting time on long tests when generated source files are stale. There is no change to application code, no security fix, and no vulnerability.
No security action required. Treat as a routine CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies .github/workflows/ci.yaml, updating the ‘needs’ dependency for three jobs (downgrade test, slow integration tests, and another integration-style job) from ‘compile’ to ‘check-compiled-source’. The ‘check-compiled-source’ job verifies that generated files are up-to-date, so this ensures expensive downstream jobs do not run if generated sources are stale. No source code, binaries, cryptography, network handling, or authentication logic is changed.
Changed components
.github/workflows/ci.yamlInspect captured patch +3 / −3
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 5b25ec00..77cb0231 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -296,7 +296,7 @@ jobs:
name: Check we can downgrade the node
runs-on: ubuntu-24.04
needs:
- - compile
+ - check-compiled-source
strategy:
fail-fast: false
matrix:
@@ -496,7 +496,7 @@ jobs:
env:
RUST_PROFILE: small # Has to match the one in the compile step
needs:
- - compile
+ - check-compiled-source
strategy:
fail-fast: false
matrix:
@@ -557,7 +557,7 @@ jobs:
SLOW_MACHINE: 1
TEST_DEBUG: 1
needs:
- - compile
+ - check-compiled-source
strategy:
fail-fast: false
matrix:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.