pytest: remove now-invalid test.
What the developer wrote
Authored by Rusty Russell
pytest: remove now-invalid test.
Commit 888745be163efe02345e944f7e7d501d64e3744c (dev_disconnect:
remove @ marker.) in v0.11 in April 2022) removed the '@' marker from
our dev_disconnect code, but one test still uses it.
Refactoring this code made it crash on invalid input. The test
triggered a db issue which has been long fixed, so I'm simply removing
it.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit simply deletes an outdated test from the test suite. The test used a '@' marker that was removed from the codebase in 2022, so it no longer works. There is no change to production code and no security issue is being fixed.
No security action needed. This is a test-suite cleanup. Reviewers may optionally verify that the referenced historical database issue is indeed already resolved elsewhere.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes test_inflight_dbload from tests/test_opening.py. The test relied on the ‘@WIRE_COMMITMENT_SIGNED’ syntax for dev_disconnect, which was removed in commit 888745be163efe02345e944f7e7d501d64e3744c (v0.11, April 2022). The commit message states that refactoring made invalid input crash, and the database issue the test was meant to exercise has long been fixed, so the test is being removed rather than updated.
Changed components
tests/test_opening.pyInspect captured patch +0 / −30
diff --git a/tests/test_opening.py b/tests/test_opening.py
index f400896d..8348ba2f 100644
--- a/tests/test_opening.py
+++ b/tests/test_opening.py
@@ -1536,36 +1536,6 @@ def test_funder_contribution_limits(node_factory, bitcoind):
assert l3.daemon.is_in_log(r'calling `signpsbt` .* 6 inputs')
-@pytest.mark.openchannel('v2')
-def test_inflight_dbload(node_factory, bitcoind):
- """Bad db field access breaks Postgresql on startup with opening leases"""
- disconnects = ["@WIRE_COMMITMENT_SIGNED"]
-
- opts = [{'experimental-dual-fund': None, 'dev-no-reconnect': None,
- 'may_reconnect': True, 'disconnect': disconnects},
- {'experimental-dual-fund': None, 'dev-no-reconnect': None,
- 'may_reconnect': True, 'funder-policy': 'match',
- 'funder-policy-mod': 100, 'lease-fee-base-sat': '100sat',
- 'lease-fee-basis': 100}]
-
- l1, l2 = node_factory.get_nodes(2, opts=opts)
-
- feerate = 2000
- amount = 500000
- l1.fundwallet(20000000)
- l2.fundwallet(20000000)
-
- # l1 leases a channel from l2
- l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
- rates = l1.rpc.dev_queryrates(l2.info['id'], amount, amount)
- l1.rpc.fundchannel(l2.info['id'], amount, request_amt=amount,
- feerate='{}perkw'.format(feerate),
- compact_lease=rates['compact_lease'])
- l1.daemon.wait_for_log(r'dev_disconnect: @WIRE_COMMITMENT_SIGNED')
-
- l1.restart()
-
-
def test_zeroconf_mindepth(bitcoind, node_factory):
"""Check that funder/fundee can customize mindepth.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.