CI: check that wire format is correct.
What the developer wrote
Authored by Rusty Russell
CI: check that wire format is correct.
Regenerate the CSV files from the specs, apply the wire/extracted*.patch files and
make sure they are up-to-date.
This catches people editing the files: if you want to change them, you have to create
a new patch file.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit adds a new automated CI check that ensures wire protocol CSV files and their associated patches stay in sync with the official BOLT specifications. It does not change any runtime code, protocol handling, or user-facing behavior. It is purely a build/validation improvement to catch manual edits that should instead go through patch files.
No security action required. Treat as a normal build/CI hygiene improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The Makefile change introduces a check-wire-format target that runs extract-bolt-csv and then verifies with git diff --exit-code HEAD that no generated CSV files or applied patches have drifted from the committed state. This target is added as a dependency of check-source, so it runs during source-quality CI. There is no modification to source code, cryptography, networking logic, or data handling.
Changed components
MakefileCI/source-check pipelineInspect captured patch +4 / −1
diff --git a/Makefile b/Makefile
index 223d383e..c8ddeb8b 100644
--- a/Makefile
+++ b/Makefile
@@ -664,8 +664,11 @@ update-doc-examples:
check-doc-examples: update-doc-examples
git diff --exit-code HEAD
+check-wire-format: extract-bolt-csv
+ git diff --exit-code HEAD
+
# This should NOT compile things!
-check-source: check-makefile check-whitespace check-spelling check-python-flake8 check-includes check-shellcheck check-setup_locale check-tmpctx check-discouraged-functions check-amount-access check-bad-sprintf
+check-source: check-makefile check-whitespace check-spelling check-python-flake8 check-includes check-shellcheck check-setup_locale check-tmpctx check-discouraged-functions check-amount-access check-bad-sprintf check-wire-format
full-check: check check-source
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.