plugins/sql: remove unneeded TODO entries.
What the developer wrote
Authored by Rusty Russell
plugins/sql: remove unneeded TODO entries.
1. Refresh time would say "dont refresh if it's only this old" but
better is to simply make refresh more efficient, which we've done
and continue to do.
2. time_msec could be used in two places, but floating point suffices.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit simply removes two outdated TODO comments from the SQL plugin source code. No code behavior changed, no bugs were fixed, and no security issue is present.
No action needed. This is a non-functional cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes two lines from a TODO comment block in plugins/sql.c: ‘2. Refresh time in API.’ and ‘8. time_msec fields.’ The commit message explains these items are no longer needed because refresh efficiency has improved and floating-point time is sufficient. There are no functional code changes.
Changed components
plugins/sql.cInspect captured patch +0 / −2
diff --git a/plugins/sql.c b/plugins/sql.c
index 24c3b28c..7712b8be 100644
--- a/plugins/sql.c
+++ b/plugins/sql.c
@@ -24,8 +24,6 @@ static const char schemas[] =
;
/* TODO:
- * 2. Refresh time in API.
- * 8. time_msec fields.
* 10. General pagination API (not just chainmoves and channelmoves)
* 11. Normalize account_id fields into another table, as they are highly duplicate, and use views to maintain the current API.
*/
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.