Release: do docker make inside uv run.
What the developer wrote
Authored by Rusty Russell
Release: do docker make inside uv run.
Here's the error inside docker:
```
wiregen common/status_wiregen.h
Traceback (most recent call last):
File "/build/tools/generate-wire.py", line 27, in <module>
from mako.template import Template
ModuleNotFoundError: No module named 'mako'
rm external/build-x86_64-redhat-linux/libwally-core-build/src/secp256k1/libsecp256k1.la
make: *** [Makefile:328: common/status_wiregen.h] Error 1
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This is a build-script fix for the Core Lightning release process. When building inside Docker, the script now runs the `make` commands inside the project's Python environment (managed by `uv`) so that required Python modules like `mako` are found. It is a build reliability fix, not a security patch.
No security action required. Treat as a normal build/maintenance fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies tools/build-release.sh so that, in the --inside-docker path, make and make install are invoked via uv run. This ensures the Python dependencies exported by uv (including mako, used by tools/generate-wire.py) are available during the build. Without this, the Docker release build fails because make runs outside the uv virtual environment and cannot import mako.
Changed components
tools/build-release.shInspect captured patch +2 / −2
diff --git a/tools/build-release.sh b/tools/build-release.sh
index b52a3362..fb647890 100755
--- a/tools/build-release.sh
+++ b/tools/build-release.sh
@@ -15,8 +15,8 @@ if [ "$1" = "--inside-docker" ]; then
uv export --format requirements.txt > /tmp/requirements.txt
uv pip install -r /tmp/requirements.txt
./configure
- make VERSION="$VER"
- make install DESTDIR=/"$VER-$PLTFM-$PLTFMVER-$ARCH" RUST_PROFILE=release
+ uv run make VERSION="$VER"
+ uv run make install DESTDIR=/"$VER-$PLTFM-$PLTFMVER-$ARCH" RUST_PROFILE=release
cd /"$VER-$PLTFM-$PLTFMVER-$ARCH" && tar cvfz /release/clightning-"$VER-$PLTFM-$PLTFMVER-$ARCH".tar.gz -- *
echo "Inside docker: build finished"
exit 0
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.