pytest: expect slow commands with giant commando test
What the developer wrote
Authored by Rusty Russell
pytest: expect slow commands with giant commando test
```
2025-12-10T02:51:06.2435409Z [gw1] [ 77%] ERROR tests/test_plugin.py::test_commando
...lightningd-1: had BROKEN messages
...
2025-12-10T03:00:26.0440311Z lightningd-1 2025-12-10T02:51:01.548Z UNUSUAL jsonrpc#69: That's weird: Request checkrune took 5961 milliseconds
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit only adjusts a test so that a known slow operation no longer causes test failures. It is not a security fix and does not change any production code.
No security action needed. This is a test-only tolerance change for slow performance under valgrind.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/test_plugin.py::test_commando to add a ‘broken_log’ regex that ignores ‘That’s weird: Request .* took’ messages. The commit message explains that under valgrind, checking a rune against a 400k command can be slow, which previously caused CI failures labeled as BROKEN messages. No runtime code is changed.
Changed components
tests/test_plugin.pyInspect captured patch +2 / −1
diff --git a/tests/test_plugin.py b/tests/test_plugin.py
index 1b549926..f51e45c3 100644
--- a/tests/test_plugin.py
+++ b/tests/test_plugin.py
@@ -2845,7 +2845,8 @@ def test_plugin_shutdown(node_factory):
def test_commando(node_factory, executor):
l1, l2 = node_factory.line_graph(2, fundchannel=False,
- opts={'log-level': 'io'})
+ # Under valgrind, checkrune of 400k command can be slow!
+ opts={'log-level': 'io', 'broken_log': "That's weird: Request .* took"})
rune = l1.rpc.createrune()['rune']
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.