AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 17 Bitcoin

bkpr-report: make ? work as expected on amount fields.

Public commit record

What the developer wrote

Authored by Rusty Russell

75/100 · Adequate
bkpr-report: make ? work as expected on amount fields.

They should test if it's zero, not if it's present.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit fixes a small behavior bug in the bookkeeper plugin's report formatting. Previously, the '?' fallback feature in report templates checked whether an amount field was present, not whether it was zero. Now, for amount fields like credit, debit, fees, and creditdebit, '?' treats a zero value as if the field were missing, so fallback text is used as users would expect. This is a correctness/usability fix, not a security vulnerability.

Recommended action

No security action required. Treat as a normal bug fix and include in regular release testing.

Security signals we found

01

No memory safety issues evident

02

No input validation bypass

03

No privilege escalation or authentication change

04

No cryptographic or consensus code touched

05

Behavioral correctness fix in RPC output formatting

Risk score

Why this scored 17/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.