CI: do cargo test --all as part of post-build step
What the developer wrote
Authored by Rusty Russell
CI: do cargo test --all as part of post-build step
No point spending 1m24 seconds for *each* different compiler variant.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit simply reorganizes the project's automated testing pipeline. It moves a Rust test step ('cargo test --all') from one place in the CI workflow to another so it runs once after builds instead of once per compiler variant. There is no change to the actual Core Lightning software, its configuration, or its security behavior.
No security action needed. This is a benign CI workflow optimization.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/ci.yaml only. It removes the ‘Check rust packages’ step (cargo test –all) from the build matrix job and adds it to a post-build check job. This is a pure CI optimization to reduce redundant test execution time. No source code, dependencies, permissions, secrets, or runtime logic are changed.
Changed components
.github/workflows/ci.yamlInspect captured patch +2 / −2
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 480cf81d..cd57c141 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -164,8 +164,6 @@ jobs:
# Rename now so we don't clash
mv testpack.tar.bz2 cln-${CFG}.tar.bz2
- - name: Check rust packages
- run: cargo test --all
- uses: actions/upload-artifact@v4
with:
name: cln-${{ matrix.CFG }}.tar.bz2
@@ -207,6 +205,8 @@ jobs:
- name: Check
run: |
uv run eatmydata make -j $(nproc) check-source-bolt check-python check-gen-updated check-doc
+ - name: Check rust packages
+ run: cargo test --all
check-units:
# The unit test checks are not in the critical path (not dependent
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.