Makefile: update so we know next version is v25.12
What the developer wrote
Authored by Rusty Russell
Makefile: update so we know next version is v25.12
And add broken-log suppression to the tests which use deprecated features on their last gasp.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit is a routine maintenance update. It bumps the planned next release version from v25.09 to v25.12 in the Makefile and adds log-message suppressions to a few test cases that intentionally use deprecated features. There is no security-relevant code change.
No security action needed. This is a benign version-bump and test-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes CLN_NEXT_VERSION in Makefile from v25.09 to v25.12. In tests/test_pay.py it replaces a deprecated decodepay RPC call with decode and suppresses the expected ‘DEPRECATED API USED decodepay’ broken-log warning for the remaining decodepay test. In tests/test_xpay.py it suppresses the broken-log warning for deprecated xpay.ignore_bolt12_mpp usage. These are test-harness cleanups accompanying a release version bump.
Changed components
Makefiletests/test_pay.pytests/test_xpay.pyInspect captured patch +5 / −3
diff --git a/Makefile b/Makefile
index f88b3e7a..e67f0ca7 100644
--- a/Makefile
+++ b/Makefile
@@ -4,7 +4,7 @@
VERSION=$(shell git describe --tags --always --dirty=-modded --abbrev=7 2>/dev/null || pwd | sed -n 's|.*/c\{0,1\}lightning-v\{0,1\}\([0-9a-f.rc\-]*\)$$|v\1|gp')
# Next release.
-CLN_NEXT_VERSION := v25.09
+CLN_NEXT_VERSION := v25.12
# --quiet / -s means quiet, dammit!
ifeq ($(findstring s,$(word 1, $(MAKEFLAGS))),s)
diff --git a/tests/test_pay.py b/tests/test_pay.py
index 151d5603..ab78f76a 100644
--- a/tests/test_pay.py
+++ b/tests/test_pay.py
@@ -5441,7 +5441,7 @@ def test_invoice_pay_desc_with_quotes(node_factory):
invoice = l2.rpc.invoice(label="test12345", amount_msat=1000,
description=description, deschashonly=True)["bolt11"]
- l1.rpc.decodepay(invoice, description)
+ l1.rpc.decode(invoice)
# pay an invoice
l1.rpc.pay(invoice, description=description)
@@ -6048,7 +6048,8 @@ def test_fetch_no_description_with_amount(node_factory):
def test_decodepay(node_factory, chainparams):
"""Test we don't break (deprecated) decodepay command"""
- l1 = node_factory.get_node(options={'allow-deprecated-apis': True})
+ l1 = node_factory.get_node(options={'allow-deprecated-apis': True},
+ broken_log="DEPRECATED API USED decodepay")
addr1 = l1.rpc.newaddr('bech32')['bech32']
addr2 = '2MxqzNANJNAdMjHQq8ZLkwzooxAFiRzXvEz' if not chainparams['elements'] else 'XGx1E2JSTLZLmqYMAo3CGpsco85aS7so33'
diff --git a/tests/test_xpay.py b/tests/test_xpay.py
index ca464c80..1244e54c 100644
--- a/tests/test_xpay.py
+++ b/tests/test_xpay.py
@@ -665,6 +665,7 @@ def test_xpay_bolt12_no_mpp(node_factory, chainparams, deprecations):
if deprecations is True:
for o in opts:
o['allow-deprecated-apis'] = True
+ o['broken_log'] = 'DEPRECATED API USED: xpay.ignore_bolt12_mpp'
l1, l2, l3, l4 = node_factory.get_nodes(4, opts=opts)
node_factory.join_nodes([l1, l2, l3], wait_for_announce=True)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.