CI: Don't explicitly invoke .github/scripts/install-bitcoind.sh
What changed, and why it matters
This is a routine cleanup of the project's automated CI (Continuous Integration) workflow file. It removes duplicated steps by letting a single setup script handle installing bitcoind, updating package lists, and installing valgrind. There is no change to the actual Core Lightning software that users run, and no security issue is present.
No security action needed. Treat as normal CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit refactors .github/workflows/ci.yaml. It removes explicit calls to .github/scripts/install-bitcoind.sh, removes redundant sudo apt-get update -qq and sudo apt-get install -yyq valgrind calls, and instead passes the TEST_NETWORK environment variable into the existing setup.sh invocation so that the setup script can perform those tasks. This is a CI maintenance change only.
Changed components
.github/workflows/ci.yamlInspect captured patch +18 / −16
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 8fb75e60..480cf81d 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -82,6 +82,8 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
# We're going to check BOLT quotes, so get the latest version
@@ -141,6 +143,8 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
@@ -184,6 +188,8 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
@@ -233,9 +239,10 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
- sudo apt-get update -qq
# We're going to check BOLT quotes, so get the latest version
git clone https://github.com/lightning/bolts.git ../${BOLTDIR}
@@ -267,6 +274,8 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
@@ -307,13 +316,10 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
- run: |
- bash -x .github/scripts/setup.sh
-
- - name: Install bitcoind
env:
TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
- run: .github/scripts/install-bitcoind.sh
+ run: |
+ bash -x .github/scripts/setup.sh
- name: Download build
uses: actions/download-artifact@v4
@@ -426,13 +432,10 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
- run: |
- bash -x .github/scripts/setup.sh
-
- - name: Install bitcoind
env:
TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
- run: .github/scripts/install-bitcoind.sh
+ run: |
+ bash -x .github/scripts/setup.sh
- name: Download build
uses: actions/download-artifact@v4
@@ -534,8 +537,6 @@ jobs:
- name: Install dependencies
run: |
- sudo apt-get update -qq
- sudo apt-get install -yyq valgrind
bash -x .github/scripts/setup.sh
- name: Install bitcoind
@@ -627,12 +628,11 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
- - name: Install bitcoind
- run: .github/scripts/install-bitcoind.sh
-
- name: Download build
uses: actions/download-artifact@v4
with:
@@ -734,6 +734,8 @@ jobs:
uses: astral-sh/setup-uv@v5
- name: Install dependencies
+ env:
+ TEST_NETWORK: ${{ matrix.TEST_NETWORK }}
run: |
bash -x .github/scripts/setup.sh
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.