CI: Don't manually install bitcoind again.
What changed, and why it matters
This commit removes two redundant steps from the project's automated testing workflow. The removed steps manually installed Bitcoin Core (bitcoind), but the setup script already handles that installation and uses caching. There is no security-relevant change to the software itself or to how users interact with it.
No security action needed. Treat as routine CI hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes duplicate ‘Install bitcoind’ steps from .github/workflows/ci.yaml. The preceding ‘Install dependencies’ step already runs .github/scripts/setup.sh, which now installs bitcoind and caches it. The change is purely a CI maintenance cleanup with no functional, cryptographic, or network behavior changes.
Changed components
.github/workflows/ci.yamlInspect captured patch +1 / −7
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index fe1394b3..cf458b46 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -660,9 +660,6 @@ jobs:
run: |
bash -x .github/scripts/setup.sh
- - name: Install bitcoind
- run: .github/scripts/install-bitcoind.sh
-
- name: Download build
uses: actions/download-artifact@v4
with:
@@ -788,10 +785,7 @@ jobs:
- name: Install dependencies
run: |
bash -x .github/scripts/setup.sh
- - name: Install bitcoind
- env:
- TEST_NETWORK: regtest
- run: .github/scripts/install-bitcoind.sh
+
- name: Download build
uses: actions/download-artifact@v4
with:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.