pytest: actually test channel_type when negotiating prviate channel.
What the developer wrote
Authored by Rusty Russell
pytest: actually test channel_type when negotiating prviate channel.
Makes sure we don't break it!
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit adds a single assertion to an existing test to verify that private channels include the expected 'scid_alias/even' channel type. It is purely a test improvement and does not change any production code, fix a bug, or address a security issue.
No action required. This is a benign test-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/test_opening.py in the test_scid_alias_private function. It captures the result of l2.rpc.fundchannel(…, announce=False) and asserts that ‘scid_alias/even’ is present in the returned channel_type names. This strengthens test coverage for private channel negotiation behavior but has no runtime security effect.
Changed components
tests/test_opening.pyInspect captured patch +2 / −1
diff --git a/tests/test_opening.py b/tests/test_opening.py
index f218d2ea..eb8a4ced 100644
--- a/tests/test_opening.py
+++ b/tests/test_opening.py
@@ -1999,7 +1999,8 @@ def test_scid_alias_private(node_factory, bitcoind):
{'log-level': 'io'}])
l2.fundwallet(5000000)
- l2.rpc.fundchannel(l3.info['id'], 'all', announce=False)
+ fc = l2.rpc.fundchannel(l3.info['id'], 'all', announce=False)
+ assert 'scid_alias/even' in fc['channel_type']['names']
bitcoind.generate_block(1, wait_for_mempool=1)
wait_for(lambda: only_one(l2.rpc.listpeerchannels(l3.info['id'])['channels'])['state'] == 'CHANNELD_NORMAL')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.