ci: Add new `version-vls` tag for Docker image
What the developer wrote
Authored by ShahanaFarooqui
ci: Add new `version-vls` tag for Docker image
Changelog-Added: Added a new `version-vls` tag with includes VLS's `remote_hsmd_socket` binary with the Core Lightning image.
What changed, and why it matters
This commit is a routine update to the project's automated Docker publishing workflow. It adds a second Docker image variant tagged with '-vls' that includes an extra signer component from the Validating Lightning Signer (VLS) project. There is no code change to Core Lightning itself, no bug fix, and no security patch.
No security action needed. Review as normal CI/infrastructure change if desired.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change modifies .github/workflows/docker-release.yml to use a build matrix producing two Docker image targets: the existing lightningd image and a new lightningd-vls-signer image. The new variant is tagged with a ‘-vls’ suffix and includes VLS’s remote_hsmd_socket binary. The workflow also enables GitHub Actions cache and renames a step. No application source code is changed.
Changed components
.github/workflows/docker-release.ymlInspect captured patch +19 / −6
diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml
index 64a64995..03dbced8 100644
--- a/.github/workflows/docker-release.yml
+++ b/.github/workflows/docker-release.yml
@@ -1,4 +1,4 @@
-name: Build and push multi-platform docker images
+name: Publish multi-platform docker images
on:
push:
@@ -30,6 +30,14 @@ on:
jobs:
build:
runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false # Let each tag finish.
+ matrix:
+ include:
+ - target: lightningd
+ tag_suffix: ''
+ - target: lightningd-vls-signer
+ tag_suffix: '-vls'
steps:
- name: Checkout repository
@@ -50,7 +58,7 @@ jobs:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- - name: Set up values
+ - name: Set up values for ${{ matrix.target }}
id: set-values
run: |
if [[ "${{ github.event.inputs.version }}" != "" ]]; then
@@ -89,14 +97,16 @@ jobs:
fi
echo "PUSHLATEST=$PUSHLATEST" >> $GITHUB_ENV
- TAGS="$REPONAME/lightningd:$VERSION"
+ TAGS="$REPONAME/lightningd:$VERSION${{ matrix.tag_suffix }}"
if [[ "$PUSHLATEST" == "true" ]]; then
- TAGS="$TAGS,$REPONAME/lightningd:latest"
+ TAGS="$TAGS,$REPONAME/lightningd:latest${{ matrix.tag_suffix }}"
fi
echo "TAGS=$TAGS" >> $GITHUB_ENV
- name: Print GitHub Ref Values
run: |
+ echo "TARGET: ${{ matrix.target }}"
+ echo "TAG SUFFIX: ${{ matrix.tag_suffix }}"
echo "GITHUB REF TYPE: ${{ github.ref_type }}"
echo "GITHUB REF NAME: ${{ github.ref_name }}"
echo "EVENT INPUT VERSION: ${{ github.event.inputs.version }}"
@@ -109,13 +119,16 @@ jobs:
echo "ENV PUSH LATEST: ${{ env.PUSHLATEST }}"
echo "ENV TAGS: ${{ env.TAGS }}"
- - name: Build and push Docker image
+ - name: Build and push Docker tag - ${{ env.TAGS }}
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfile
+ target: ${{ matrix.target }}
push: true
platforms: ${{ env.PLATFORMS }}
tags: ${{ env.TAGS }}
build-args: |
- VERSION=${{ env.VERSION }}
\ No newline at end of file
+ VERSION=${{ env.VERSION }}
+ cache-from: type=gha
+ cache-to: type=gha,mode=max
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.