build: suppress amount checking in fuzzing tests.
What the developer wrote
Authored by Rusty Russell
build: suppress amount checking in fuzzing tests.
```
tests/fuzz/fuzz-funder-policy.c:32: amt.satoshis %= (MAX_SATS + 1);
tests/fuzz/fuzz-funder-policy.c:132: total.satoshis, tcase->max_channel_size.satoshis);
tests/fuzz/fuzz-funder-policy.c:140: our_funds.satoshis, tcase->policy.per_channel_min.satoshis);
tests/fuzz/fuzz-funder-policy.c:145: our_funds.satoshis, tcase->policy.per_channel_max.satoshis);
tests/fuzz/fuzz-funder-policy.c:155: our_funds.satoshis, tcase->available_funds.satoshis,
tests/fuzz/fuzz-funder-policy.c:156: tcase->policy.reserve_tank.satoshis);
tests/fuzz/fuzz-funder-policy.c:161: tcase->policy.reserve_tank.satoshis, tcase->available_funds.satoshis,
tests/fuzz/fuzz-funder-policy.c:162: our_funds.satoshis);
make: *** [Makefile:577: check-amount-access] Error 1
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This change only adds comments to a fuzz-testing file so that an internal build check no longer flags direct access to Bitcoin amount fields. It does not change any executable code or fix a security bug in the live Lightning node software.
No security action required. Treat as a normal build/test hygiene commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit annotates six direct .satoshis field accesses in tests/fuzz/fuzz-funder-policy.c with /* Raw: fuzzing */ comments. These annotations tell Core Lightning’s check-amount-access Makefile rule to ignore the accesses. The code behavior is identical before and after the patch; the change is purely to satisfy a build-time lint used during fuzz-test compilation.
Changed components
tests/fuzz/fuzz-funder-policy.cInspect captured patch +8 / −8
diff --git a/tests/fuzz/fuzz-funder-policy.c b/tests/fuzz/fuzz-funder-policy.c
index a3f80aaa..c3a42c5d 100644
--- a/tests/fuzz/fuzz-funder-policy.c
+++ b/tests/fuzz/fuzz-funder-policy.c
@@ -29,7 +29,7 @@ struct test_case {
static struct amount_sat fromwire_amount_sat_bounded(const u8 **cursor, size_t *max)
{
struct amount_sat amt = fromwire_amount_sat(cursor, max);
- amt.satoshis %= (MAX_SATS + 1);
+ amt.satoshis %= (MAX_SATS + 1); /* Raw: fuzzing */
return amt;
}
@@ -129,7 +129,7 @@ void run(const u8 *data, size_t size)
}
if (amount_sat_greater(total, tcase->max_channel_size)) {
fprintf(stderr, "Total channel capacity %"PRIu64" exceeds size %"PRIu64"\n",
- total.satoshis, tcase->max_channel_size.satoshis);
+ total.satoshis, tcase->max_channel_size.satoshis); /* Raw: fuzzing */
abort();
}
@@ -137,12 +137,12 @@ void run(const u8 *data, size_t size)
if (amount_sat_less(our_funds, tcase->policy.per_channel_min) &&
!amount_sat_is_zero(our_funds)) {
fprintf(stderr, "our_funds %"PRIu64" < per_channel_min %"PRIu64"\n",
- our_funds.satoshis, tcase->policy.per_channel_min.satoshis);
+ our_funds.satoshis, tcase->policy.per_channel_min.satoshis); /* Raw: fuzzing */
abort();
}
if (amount_sat_greater(our_funds, tcase->policy.per_channel_max)) {
fprintf(stderr, "our_funds %"PRIu64" > per_max_channel_size %"PRIu64"\n",
- our_funds.satoshis, tcase->policy.per_channel_max.satoshis);
+ our_funds.satoshis, tcase->policy.per_channel_max.satoshis); /* Raw: fuzzing */
abort();
}
}
@@ -152,14 +152,14 @@ void run(const u8 *data, size_t size)
if (amount_sat_sub(&available_minus_reserve, tcase->available_funds, tcase->policy.reserve_tank)) {
if (amount_sat_greater(our_funds, available_minus_reserve)) {
fprintf(stderr, "our_funds %"PRIu64" > available %"PRIu64" - reserve %"PRIu64"\n",
- our_funds.satoshis, tcase->available_funds.satoshis,
- tcase->policy.reserve_tank.satoshis);
+ our_funds.satoshis, tcase->available_funds.satoshis, /* Raw: fuzzing */
+ tcase->policy.reserve_tank.satoshis); /* Raw: fuzzing */
abort();
}
} else if (!amount_sat_eq(our_funds, AMOUNT_SAT(0))) {
fprintf(stderr, "Reserve %"PRIu64" >= available %"PRIu64" but our_funds %"PRIu64" != 0\n",
- tcase->policy.reserve_tank.satoshis, tcase->available_funds.satoshis,
- our_funds.satoshis);
+ tcase->policy.reserve_tank.satoshis, tcase->available_funds.satoshis, /* Raw: fuzzing */
+ our_funds.satoshis); /* Raw: fuzzing */
abort();
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.