test: mark bookkeeper test to use old hsm secret
What the developer wrote
Authored by Sangbida Chaudhuri
test: mark bookkeeper test to use old hsm secret
bookkeeper's fee tracking depends on deterministic channel structure, which depends on node ID ordering. I'm marking this with the old_hsmsecret option for now.
What changed, and why it matters
This commit only changes a single test file. It adds an option called 'old_hsmsecret' to a test setup so that the bookkeeper test produces deterministic (predictable) channel data. There is no change to production code, no bug fix, and no security patch.
No security action needed. This is a test-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/test_bookkeeper.py, passing opts={‘old_hsmsecret’: True} to node_factory.line_graph(2) in test_bookkeeping_closing_trimmed_htlcs. The commit message explains this is to preserve deterministic node ID ordering for fee-tracking assertions. No runtime code is touched.
Changed components
tests/test_bookkeeper.pyInspect captured patch +1 / −1
diff --git a/tests/test_bookkeeper.py b/tests/test_bookkeeper.py
index 7da7cab0..5160261e 100644
--- a/tests/test_bookkeeper.py
+++ b/tests/test_bookkeeper.py
@@ -31,7 +31,7 @@ def check_events(node, channel_id, exp_events):
@unittest.skipIf(TEST_NETWORK != 'regtest', "fixme: broadcast fails, dusty")
def test_bookkeeping_closing_trimmed_htlcs(node_factory, bitcoind, executor):
- l1, l2 = node_factory.line_graph(2)
+ l1, l2 = node_factory.line_graph(2, opts={'old_hsmsecret': True})
# Send l2 funds via the channel
l1.pay(l2, 11000000)
Why this scored 14/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.