splice: Enable the splice in default settings
What the developer wrote
Authored by Dusty Daemon
splice: Enable the splice in default settings
Turn splicing on by default for channel feature sets!
Changelog-Deprecated Splicing is now enabled by default!
What changed, and why it matters
This commit turns on a new Lightning protocol feature called 'splicing' by default. Splicing lets users add or remove funds from an existing Lightning channel without closing and reopening it. The change itself is a simple configuration default update and does not fix any bug or vulnerability. It only affects which features a node advertises to peers and which tests expect to see in that advertisement list.
No security action required. Review splicing implementation separately if desired, but this commit is purely an enable-by-default configuration change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds OPTIONAL_FEATURE(OPT_SPLICE) to the default feature set in lightningd.c and updates test_list_features_only in tests/test_misc.py to expect ‘option_splice/odd’ in the advertised feature list. There is no code change to splicing logic, no bug fix, and no mention of security issues in the commit message or diff.
Changed components
lightningd/lightningd.c default feature advertisementtests/test_misc.py feature-list test expectationInspect captured patch +3 / −1
diff --git a/lightningd/lightningd.c b/lightningd/lightningd.c
index 3a669e1b..03ebdd1e 100644
--- a/lightningd/lightningd.c
+++ b/lightningd/lightningd.c
@@ -907,6 +907,7 @@ static struct feature_set *default_features(const tal_t *ctx)
OPTIONAL_FEATURE(OPT_PROVIDE_STORAGE),
/* Removed later for elements */
OPTIONAL_FEATURE(OPT_ANCHORS_ZERO_FEE_HTLC_TX),
+ OPTIONAL_FEATURE(OPT_SPLICE),
};
for (size_t i = 0; i < ARRAY_SIZE(features); i++) {
diff --git a/tests/test_misc.py b/tests/test_misc.py
index e53b283c..bbfbd80c 100644
--- a/tests/test_misc.py
+++ b/tests/test_misc.py
@@ -2501,7 +2501,8 @@ def test_list_features_only(node_factory):
'option_provide_storage/odd',
'option_channel_type/even',
'option_scid_alias/odd',
- 'option_zeroconf/odd']
+ 'option_zeroconf/odd',
+ 'option_splice/odd']
expected += ['supports_open_accept_channel_type']
assert features == expected
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.