AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

bookkeeper: don't use int128.

Public commit record

What the developer wrote

Authored by Rusty Russell

68/100 · Adequate
bookkeeper: don't use int128.

32-bit ARM doesn't like it :(

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Build: we now build on 32 bit systems again.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a build problem on 32-bit ARM computers by removing the use of a 128-bit integer type that those systems do not support. It changes one currency-conversion calculation in the bookkeeper plugin to use ordinary 64-bit math with a floating-point fallback, and adds a test file to check the results. There is no direct security vulnerability being patched; it is primarily a portability/build fix.

Recommended action

Treat as a routine build/portability fix. Review the double fallback path if exact accounting precision is required for extremely large msat*rate products, but no urgent security action is indicated.

Security signals we found

01

Use of non-portable 128-bit integer type removed

02

Currency conversion now uses checked 64-bit multiplication with floating-point fallback on overflow

03

New unit tests cover normal, fractional, small-amount, and overflow conversion cases

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 5/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.