configure: delete non-working "do we have Python mako" test.
What the developer wrote
Authored by Rusty Russell
configure: delete non-working "do we have Python mako" test.
It would need to run under uv. I noticed it failing while debugging the 32-bit CI build,
but it fails everywhere.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit removes a broken build-time check that tried to detect whether the Python 'mako' template library was installed. The test was failing everywhere because it needed to run under a newer Python environment manager called 'uv'. The change simply deletes the non-working detection and makes the related tool tests always run instead of being skipped. There is no security issue here.
No security action needed. Treat as a normal build-system maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the configure-time check_command 'python3-mako' python3 -c 'import mako' probe and the HAVE_PYTHON3_MAKO variable it set. It also removes the Makefile guard that skipped check-tools unless HAVE_PYTHON3_MAKO was set. The result is that the generated tool tests now always build and run. This is a build-system cleanup, not a vulnerability fix.
Changed components
configure scripttools/test/MakefileInspect captured patch +0 / −10
diff --git a/configure b/configure
index 0aa1669a..260738b2 100755
--- a/configure
+++ b/configure
@@ -536,12 +536,6 @@ code=
/*END*/
EOF
-if check_command 'python3-mako' python3 -c 'import mako'; then
- HAVE_PYTHON3_MAKO=1
-else
- HAVE_PYTHON3_MAKO=0
-fi
-
if ! check_command 'lowdown' lowdown; then
echo "*** We need lowdown!" >&2
exit 1
@@ -638,7 +632,6 @@ add_var CLANG_COVERAGE "$CLANG_COVERAGE"
add_var ASAN "$ASAN"
add_var UBSAN "$UBSAN"
add_var TEST_NETWORK "$TEST_NETWORK"
-add_var HAVE_PYTHON3_MAKO "$HAVE_PYTHON3_MAKO"
add_var SHA256SUM "$SHA256SUM"
add_var FUZZING "$FUZZING"
add_var RUST "$RUST"
diff --git a/tools/test/Makefile b/tools/test/Makefile
index edb272de..c9482c9b 100644
--- a/tools/test/Makefile
+++ b/tools/test/Makefile
@@ -6,8 +6,6 @@
# We generate the files, and then we attempt to compile
# and run a test case.
-# We don't run these at all unless mako is installed.
-ifeq ($(HAVE_PYTHON3_MAKO),1)
check-units: check-tools
TOOL_TEST_INCL_SRC := tools/test/enum.c
@@ -44,7 +42,6 @@ tools/test/print_gen.c: $(TOOLS_WIRE_DEPS)
ALL_TEST_PROGRAMS += $(TOOL_TEST_PROGRAMS)
check-tools: $(TOOL_TEST_PROGRAMS:%=unittest/%)
-endif # HAVE_PYTHON3_MAKO
clean: tools-test-clean
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.