AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 18 Bitcoin

graceful: add a timeout for user simplicity.

Public commit record

What the developer wrote

Authored by Rusty Russell

60/100 · Adequate
graceful: add a timeout for user simplicity.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit adds an optional timeout to the 'graceful' RPC command in Core Lightning, which operators use when preparing a node to shut down. Previously, graceful would wait indefinitely until all payment commitments (HTLCs) finished and idle peers disconnected. Now, if a timeout is provided, the command returns after that many seconds and reports any still-pending HTLC expiry heights and connected peers. This is a usability improvement for scripting shutdowns, not a security fix. The code changes are straightforward and do not appear to introduce a vulnerability.

Recommended action

No security action required. Treat as a normal feature commit. Reviewers may optionally verify that graceful_timeout cannot be re-entered and that the timer is canceled when the command completes normally, but the destructor addition already mitigates the main lifetime concern.

Security signals we found

01

No security-relevant signal: change is a feature/usability enhancement to an existing RPC command.

02

New RPC parameter is optional and typed u32/u64, bounded by JSON-RPC input parsing.

03

Destructor addition prevents use-after-free/list corruption if a graceful waiter is freed before completion, which is a robustness improvement rather than a confirmed vulnerability fix.

04

No mention of CVE, security advisory, bug bounty, or vulnerability disclosure in commit message or diff.

Risk score

Why this scored 18/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.