CI: Remove setup useradd line, use eatmydata
What the developer wrote
Authored by Rusty Russell
CI: Remove setup useradd line, use eatmydata
I noticed this line causing a delay; ChatGPT thinks NSS name lookup.
I've removed the useradd line altogether.
I also install eatmydata first, to try to speed the other installs.
This drops the install step from 1m45 to about 30 seconds.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This is a routine speed-up change to the project's automated build script. It removes an unused user account creation step and installs a small tool called 'eatmydata' earlier so the rest of the package installation runs faster. There is no security issue visible in the change.
No security action needed. The change can be reviewed as a normal CI optimization.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/scripts/setup.sh, a GitHub Actions CI setup script. It removes ‘sudo useradd -ms /bin/bash tester’ and installs ‘eatmydata’ before the main apt-get install run, then prefixes the main install with ‘eatmydata’. eatmydata is a well-known wrapper that disables fsync/data durability during package installs to speed them up in ephemeral CI environments. The change is purely a CI performance optimization.
Changed components
.github/scripts/setup.shInspect captured patch +5 / −2
diff --git a/.github/scripts/setup.sh b/.github/scripts/setup.sh
index 1f5d7ce9..291c4c07 100755
--- a/.github/scripts/setup.sh
+++ b/.github/scripts/setup.sh
@@ -3,14 +3,18 @@ set -e
export DEBIAN_FRONTEND=noninteractive
export RUST_VERSION=stable
-sudo useradd -ms /bin/bash tester
sudo mkdir -p /var/cache/apt/archives
mkdir -p ~/ci-cache/apt/
sudo cp -a ~/ci-cache/apt/. /var/cache/apt/archives/ 2>/dev/null || true
sudo apt-get update
+# Install eatmydata, then use it for the rest.
sudo apt-get install --no-install-recommends --allow-unauthenticated -yy \
+ -o APT::Keep-Downloaded-Packages=true \
+ eatmydata
+
+sudo eatmydata apt-get install --no-install-recommends --allow-unauthenticated -yy \
-o APT::Keep-Downloaded-Packages=true \
autoconf \
automake \
@@ -19,7 +23,6 @@ sudo apt-get install --no-install-recommends --allow-unauthenticated -yy \
clang \
cppcheck \
docbook-xml \
- eatmydata \
gcc-aarch64-linux-gnu \
gcc-arm-linux-gnueabihf \
gcc-arm-none-eabi \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.