build (macos): do not overwrite `PKG_CONFIG_PATH` variable
What the developer wrote
Authored by botantony
build (macos): do not overwrite `PKG_CONFIG_PATH` variable
What changed, and why it matters
This is a one-line build-system fix for macOS. Previously, the configure script replaced the user's PKG_CONFIG_PATH environment variable with a single hardcoded path. Now it appends the hardcoded path to any existing value. This prevents build failures when users rely on custom or Homebrew-provided pkg-config paths, but it does not fix a runtime security vulnerability in the lightning node itself.
No security action required. Treat as a normal build-system improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit changes configure line 16 from export PKG_CONFIG_PATH=/opt/homebrew/opt/sqlite/lib/pkgconfig to export PKG_CONFIG_PATH=${PKG_CONFIG_PATH}:/opt/homebrew/opt/sqlite/lib/pkgconfig. This preserves pre-existing PKG_CONFIG_PATH entries, which is a build hygiene improvement. There is no change to cryptographic, network, or consensus code, and no evidence of a security defect being patched.
Changed components
configure script (macOS arm64 build path)Inspect captured patch +1 / −1
diff --git a/configure b/configure
index f69dc157..eb135239 100755
--- a/configure
+++ b/configure
@@ -13,7 +13,7 @@ ARCH=$(uname -m)
if [ "$OS-$ARCH" = "Darwin-arm64" ]; then
CPATH=/opt/homebrew/include
LIBRARY_PATH=/opt/homebrew/lib
-export PKG_CONFIG_PATH=/opt/homebrew/opt/sqlite/lib/pkgconfig
+export PKG_CONFIG_PATH=${PKG_CONFIG_PATH}:/opt/homebrew/opt/sqlite/lib/pkgconfig
else
CPATH=/usr/local/lib
LIBRARY_PATH=/usr/local/lib
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.