What the developer wrote
Authored by Rusty Russell
fuzz: fix compilation.
Header changes in master broke this upon rebase :(
```
In file included from ./channeld/full_channel.h:5,
from tests/fuzz/fuzz-full_channel.c:7:
./channeld/channeld_htlc.h:13:28: error: field ‘amount’ has incomplete type
13 | struct amount_msat amount;
| ^~~~~~
./channeld/channeld_htlc.h:17:23: error: field ‘rhash’ has incomplete type
17 | struct sha256 rhash;
| ^~~~~
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit fixes a build failure in the fuzz testing code by adding two missing header file includes. It does not change any runtime behavior or fix a security vulnerability.
No security action required. Treat as a normal build fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit adds #include <ccan/crypto/sha256/sha256.h> and #include <common/amount.h> to channeld/channeld_htlc.h. These headers are needed because the file declares struct fields of types struct amount_msat and struct sha256, which require complete type definitions. A prior header reorganization in the codebase removed the transitive inclusion of these headers, causing the fuzz target compilation to fail with ‘field has incomplete type’ errors. The fix is purely a compilation dependency correction.
Changed components
channeld/channeld_htlc.hInspect captured patch +2 / −0
diff --git a/channeld/channeld_htlc.h b/channeld/channeld_htlc.h
index 2bd7075c..ed2efe20 100644
--- a/channeld/channeld_htlc.h
+++ b/channeld/channeld_htlc.h
@@ -1,6 +1,8 @@
#ifndef LIGHTNING_CHANNELD_CHANNELD_HTLC_H
#define LIGHTNING_CHANNELD_CHANNELD_HTLC_H
#include "config.h"
+#include <ccan/crypto/sha256/sha256.h>
+#include <common/amount.h>
#include <common/htlc.h>
#include <common/pseudorand.h>
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.