AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

pytest: use xpay, not pay in misc tests.

Public commit record

What the developer wrote

Authored by Rusty Russell

78/100 · Adequate
pytest: use xpay, not pay in misc tests.

This usually means changing the error strings, where we test them, and
avoiding `paystatus`.

Other changes:
1. Completely get rid of `test_custom_notification_topics`: xpay tests do this
already.
2. Add xpay wrapper to pyln-client so we can mix named and unnamed args.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit only changes the project's internal test suite and a Python test helper. It replaces calls to the older `pay` RPC command with the newer `xpay` command in many tests, updates expected error messages, removes one obsolete test, and adds an `xpay` wrapper to the pyln-client library so tests can call it more easily. There is no change to the actual Core Lightning daemon or wallet code that handles real payments, so this does not fix or introduce a security vulnerability.

Recommended action

No security action required. Treat as normal test-maintenance commit. Reviewers may want to confirm that the xpay wrapper's parameter list matches the current xpay RPC schema, but this is a test-helper quality issue, not a security issue.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.