common: remove unused push bit.
What the developer wrote
Authored by Rusty Russell
common: remove unused push bit.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit simply removes an unused flag bit and its display in a developer debugging tool. There is no security-relevant change: no code behavior is altered, no vulnerability is fixed, and no new risk is introduced.
No action required. This is a non-security cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the GOSSIP_STORE_PUSH_BIT (0x4000U) definition from common/gossip_store.h and removes the corresponding ‘push’ variable and ‘PUSH ’ output from devtools/dump-gossipstore.c. The bit was never used elsewhere in the diff or referenced in the supplied materials. It is a pure cleanup/refactoring change.
Changed components
common/gossip_store.hdevtools/dump-gossipstore.cInspect captured patch +2 / −9
diff --git a/common/gossip_store.h b/common/gossip_store.h
index 9da13b52..98abd5f9 100644
--- a/common/gossip_store.h
+++ b/common/gossip_store.h
@@ -29,11 +29,6 @@ struct gossip_rcvd_filter;
*/
#define GOSSIP_STORE_DELETED_BIT 0x8000U
-/**
- * Bit of flags we use to mark an important record.
- */
-#define GOSSIP_STORE_PUSH_BIT 0x4000U
-
/**
* Bit of flags used to mark a channel announcement closed (not deleted for 12 blocks)
*/
diff --git a/devtools/dump-gossipstore.c b/devtools/dump-gossipstore.c
index 6cd6d29b..70cee3eb 100644
--- a/devtools/dump-gossipstore.c
+++ b/devtools/dump-gossipstore.c
@@ -67,20 +67,18 @@ int main(int argc, char *argv[])
u16 flags = be16_to_cpu(hdr.flags);
u16 msglen = be16_to_cpu(hdr.len);
u8 *msg, *inner;
- bool deleted, push, dying;
+ bool deleted, dying;
u32 blockheight;
deleted = (flags & GOSSIP_STORE_DELETED_BIT);
- push = (flags & GOSSIP_STORE_PUSH_BIT);
dying = (flags & GOSSIP_STORE_DYING_BIT);
msg = tal_arr(NULL, u8, msglen);
if (read(fd, msg, msglen) != msglen)
errx(1, "%zu: Truncated file?", off);
- printf("%zu: %s%s%s%s", off,
+ printf("%zu: %s%s%s", off,
deleted ? "DELETED " : "",
- push ? "PUSH " : "",
dying ? "DYING " : "",
be32_to_cpu(hdr.crc) != crc32c(be32_to_cpu(hdr.timestamp), msg, msglen) ? "**BAD CHECKSUM** " : "");
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.