AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 18 Bitcoin

connectd: don't complain if lightningd is unresponsive while doing dev-memleak.

Public commit record

What the developer wrote

Authored by Rusty Russell

73/100 · Adequate
connectd: don't complain if lightningd is unresponsive while doing dev-memleak.

We had a flake of form:

```
2025-11-18T04:42:23.489Z **BROKEN** 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-connectd: wake delay for WIRE_CHANNEL_REESTABLISH: 6789msec
```

Which happened as we're shutting down. Some investigation revealed
the cause: `dev-memleak` can be extremely slow. Fair enough.

So we change `dev-memleak` to call connectd first, and connectd uses
that as a trigger to stop complaining about delays.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This is a developer-only fix for a flaky test. The `dev-memleak` diagnostic tool can take so long that another component (connectd) thought the main daemon had hung, logging a scary but harmless 'BROKEN' message that broke automated tests. The patch makes connectd suppress that complaint while `dev-memleak` is running. It is not a security vulnerability fix and does not change normal node behavior.

Recommended action

No security action required. Treat as a normal test-flakiness / developer-tool improvement.

Security signals we found

01

No security-relevant code path modified

02

Change is gated behind developer-only `dev-memleak` command

03

Only effect is suppression of an internal diagnostic warning

04

No input validation, memory safety, or privilege boundary changes

Risk score

Why this scored 18/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 1/15
Affected reach 2/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.