pytest: fix flake if rune tests are slow.
What the developer wrote
Authored by Rusty Russell
pytest: fix flake if rune tests are slow.
If one second has passed during testing, checkrune might pass:
```
# default (sec)
rune_per_default = l1.rpc.createrune(restrictions=[["per=1"]])['rune']
assert rune_per_default == 'NrM7go6C4qzfRQDkUSv1DtRroJWSKqdjIOuvGS4TLFE9NCZwZXI9MQ=='
> do_test_rune_per_restriction(l1, rune_per_default, 1)
tests/test_runes.py:269:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
l1 = <fixtures.LightningNode object at 0x7f7344ad2ef0>
rune_to_test = 'NrM7go6C4qzfRQDkUSv1DtRroJWSKqdjIOuvGS4TLFE9NCZwZXI9MQ=='
per_sec = 1
def do_test_rune_per_restriction(l1, rune_to_test, per_sec):
...
# cannot use same rune till 'per_sec' seconds
> with pytest.raises(RpcError, match='Not permitted:') as exc_info:
E Failed: DID NOT RAISE <class 'pyln.client.lightning.RpcError'>
tests/test_runes.py:217: Failed
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit only changes test code. It makes a flaky test more reliable by increasing the time window used in rune rate-limit tests from 1 second to 2 seconds, so slow test machines don't accidentally pass a rate-limit check. There is no change to production code or any security fix.
No security action needed; this is a test reliability improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies tests/test_runes.py to change several createrune ‘per=’ restrictions from 1-second-equivalent values to 2-second-equivalent values, and updates the expected rune base64 strings accordingly. The helper do_test_rune_per_restriction expects an RpcError when reusing a rune within the configured period. On slow CI runners, more than 1 second could elapse between uses, causing the expected error not to be raised and the test to flake. Doubling the period reduces that timing race. No Core Lightning runtime code is touched.
Changed components
tests/test_runes.pyInspect captured patch +9 / −9
diff --git a/tests/test_runes.py b/tests/test_runes.py
index 4c080a8b..ad21719c 100644
--- a/tests/test_runes.py
+++ b/tests/test_runes.py
@@ -244,9 +244,9 @@ def test_createrune_per_restriction(node_factory):
l1 = node_factory.get_node()
# 1 sec = 1,000,000,000 nanoseconds (nsec)
- rune_per_nano_sec = l1.rpc.createrune(restrictions=[["per=1000000000nsec"]])['rune']
- assert rune_per_nano_sec == 'Bl0V_vkVkGr4h356JbCMCcoDyyKE8djkoQ2156iPB509MCZwZXI9MTAwMDAwMDAwMG5zZWM='
- do_test_rune_per_restriction(l1, rune_per_nano_sec, 1)
+ rune_per_nano_sec = l1.rpc.createrune(restrictions=[["per=2000000000nsec"]])['rune']
+ assert rune_per_nano_sec == 'FU709V1zX-JJR2hlpBfN2hpPEqahtzi6q65fZxnRRhM9MCZwZXI9MjAwMDAwMDAwMG5zZWM='
+ do_test_rune_per_restriction(l1, rune_per_nano_sec, 2)
# 1 sec = 1,000,000 microseconds (usec)
rune_per_micro_sec = l1.rpc.createrune(restrictions=[["per=2000000usec"]])['rune']
@@ -254,9 +254,9 @@ def test_createrune_per_restriction(node_factory):
do_test_rune_per_restriction(l1, rune_per_micro_sec, 2)
# 1 sec = 1,000 milliseconds (msec)
- rune_per_milli_sec = l1.rpc.createrune(restrictions=[["per=1000msec"]])['rune']
- assert rune_per_milli_sec == 'EzVpQwjYe2aoNQiRa4_s7FJtomD3kWzx7lusMpzA59w9MiZwZXI9MTAwMG1zZWM='
- do_test_rune_per_restriction(l1, rune_per_milli_sec, 1)
+ rune_per_milli_sec = l1.rpc.createrune(restrictions=[["per=2000msec"]])['rune']
+ assert rune_per_milli_sec == 'eoEyi0Na_GeXBpmQ_cXQHrvmAuGWwq4bJrYo0jKk6V09MiZwZXI9MjAwMG1zZWM='
+ do_test_rune_per_restriction(l1, rune_per_milli_sec, 2)
# 1 sec
rune_per_sec = l1.rpc.createrune(restrictions=[["per=2sec"]])['rune']
@@ -264,9 +264,9 @@ def test_createrune_per_restriction(node_factory):
do_test_rune_per_restriction(l1, rune_per_sec, 2)
# default (sec)
- rune_per_default = l1.rpc.createrune(restrictions=[["per=1"]])['rune']
- assert rune_per_default == 'NrM7go6C4qzfRQDkUSv1DtRroJWSKqdjIOuvGS4TLFE9NCZwZXI9MQ=='
- do_test_rune_per_restriction(l1, rune_per_default, 1)
+ rune_per_default = l1.rpc.createrune(restrictions=[["per=2"]])['rune']
+ assert rune_per_default == 'pd0Xr2U3uv-mJQfsp801doqTN5zpRRuc2Clp5Yb8zmU9NCZwZXI9Mg=='
+ do_test_rune_per_restriction(l1, rune_per_default, 2)
# 1 minute
rune_per_min = l1.rpc.createrune(restrictions=[["per=1min"]])['rune']
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.