CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 26 Bitcoin

common: assume OPT_PAYMENT_SECRET.

EP6c368a11 View source ↗
Public commit record

What the developer wrote

Authored by Rusty Russell

70/100 · Adequate
common: assume OPT_PAYMENT_SECRET.

This means we can assume support, but we *can't* assume it's present, because
of keysend, which doesn't use it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Descriptive subject✓ Provides detailed explanatory context✓ Explains rationale or failure mode
The short version

What changed, and why it matters

This commit changes how Core Lightning advertises support for two Lightning network features: 'payment_secret' and 'option_channel_type'. Previously these were actively announced as supported; now the code treats them as assumed to be supported by all modern nodes. The commit message notes a caveat: payment secrets still won't be present in 'keysend' payments, which don't use them. This is a protocol-level behavior change, not a fix for an active vulnerability, and the commit itself does not describe any security issue.

Recommended action

Review whether treating payment_secret and option_channel_type as assumed could cause interoperability or privacy issues with older or non-compliant peers, particularly around keysend payments lacking payment secrets. No immediate security patch appears required based on the commit alone.

Security signals we found

01

Protocol feature negotiation change

02

Payment secret handling altered for keysend compatibility

03

No explicit security claim in commit or diff

04

Bumped BOLT specification reference

Risk score

Why this scored 26/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 8/15
Confidence 4/10
Evidence quality 2/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Core Lightning

Related watches

Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

contrib: add jaonoctus's signing key

This commit simply adds a new person's PGP public-key fingerprint to the list of trusted release signers in two documentation files. It does not change any code, fix any bug, or alter any security behavior of the software itself.

41278b4eby jaonoctus+2−02 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: fixed timestamps for invented bookkeeper deposits

This is a tiny internal fix to make a bookkeeping migration produce stable event ordering. It changes the timestamp used when creating historical 'deposit' records during a one-time database migration, so the records sort consistently with…

498e5086by daywalker90+2−01 file
No security note in commit
Open full analysis →Source commit ↗
Informational 21 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: document missing and fix erroneous JSON-RPC error codes

This commit is a documentation-only cleanup of the JSON-RPC command help files. It corrects which numeric error codes are listed for each command so the published schemas match what the software actually returns. No program logic, validati…

Documentation-only change with no executable code modificationsCorrects RPC schema error-code metadata to match actual handler behaviorNo change to input parsing, authorization, cryptography, or network behavior
d1b6963bby daywalker90+204−1224 files
No security note in commit
Open full analysis →Source commit ↗