What the developer wrote
Authored by Rusty Russell
getlog: fix schema.
getlog() only gets recent logs, not all of them (since it prunes, and soon will be a ringbuffer).
And "data" is actually an optional field, not required.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit updates two JSON schema files for the getlog RPC command. It changes the title from 'Command to show logs' to 'Command to show recent logs' and marks the 'data' field as optional rather than required. These are documentation and schema accuracy corrections only; no code behavior changes.
No security action required. This is a documentation/schema maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies contrib/msggen/msggen/schema.json and doc/schemas/getlog.json. It removes ‘data’ from the required properties list for log entries and updates the title to reflect that getlog returns recent logs. The actual implementation behavior already treated ‘data’ as optional and only returned recent logs; this commit merely aligns the schema with reality.
Changed components
doc/schemas/getlog.jsoncontrib/msggen/msggen/schema.jsonInspect captured patch +4 / −6
diff --git a/contrib/msggen/msggen/schema.json b/contrib/msggen/msggen/schema.json
index 4e2b7a57..88049322 100644
--- a/contrib/msggen/msggen/schema.json
+++ b/contrib/msggen/msggen/schema.json
@@ -14818,7 +14818,7 @@
"$schema": "../rpc-schema-draft.json",
"type": "object",
"rpc": "getlog",
- "title": "Command to show logs.",
+ "title": "Command to show recent logs.",
"description": [
"The **getlog** the RPC command to show logs, with optional log *level*."
],
@@ -14992,8 +14992,7 @@
"required": [
"time",
"source",
- "log",
- "data"
+ "log"
],
"properties": {
"type": {},
diff --git a/doc/schemas/getlog.json b/doc/schemas/getlog.json
index 919d728f..650a8073 100644
--- a/doc/schemas/getlog.json
+++ b/doc/schemas/getlog.json
@@ -2,7 +2,7 @@
"$schema": "../rpc-schema-draft.json",
"type": "object",
"rpc": "getlog",
- "title": "Command to show logs.",
+ "title": "Command to show recent logs.",
"description": [
"The **getlog** the RPC command to show logs, with optional log *level*."
],
@@ -176,8 +176,7 @@
"required": [
"time",
"source",
- "log",
- "data"
+ "log"
],
"properties": {
"type": {},
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.