Informational 18 Bitcoin Committed Nov 18, 2025 · 03:58 UTC

schemas: allow CLOSED state in channel_state_changed notification.

64563c51 View source ↗

Public commit record

What the developer wrote

Authored by Rusty Russell

65/100 · Adequate

schemas: allow *CLOSED* state in channel_state_changed notification.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body

The short version

What changed, and why it matters

This commit updates two JSON schema files used by Core Lightning to document and validate a notification message. It adds 'CLOSED' as a permitted value for the channel state field in the 'channel_state_changed' notification, along with a note that this value was introduced in version 25.12. There is no code behavior change, no runtime logic change, and no security fix or vulnerability present in the diff.

Recommended action

No security action required. Treat as a normal documentation/schema maintenance commit.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The patch is purely a schema/documentation correction. It widens the enum of allowed strings for the ‘channel_state_changed’ notification’s channel state field to include ‘CLOSED’, and appends a documentation note. The change affects contrib/msggen/msggen/schema.json and doc/schemas/notification/channel_state_changed.json only. No C source, no parsing logic, no cryptographic or network code is modified.

Changed components

contrib/msggen/msggen/schema.jsondoc/schemas/notification/channel_state_changed.json

Inspect captured patch +8 / −4

diff --git a/contrib/msggen/msggen/schema.json b/contrib/msggen/msggen/schema.json
index 78f0a9dd..a69a10be 100644
--- a/contrib/msggen/msggen/schema.json
+++ b/contrib/msggen/msggen/schema.json
@@ -37731,10 +37731,12 @@
               "DUALOPEND_AWAITING_LOCKIN",
               "CHANNELD_AWAITING_SPLICE",
               "DUALOPEND_OPEN_COMMITTED",
-              "DUALOPEND_OPEN_COMMIT_READY"
+              "DUALOPEND_OPEN_COMMIT_READY",
+              "CLOSED"
             ],
             "description": [
-              "The channel state, in particular \"CHANNELD_NORMAL\" and \"CHANNELD_AWAITING_SPLICE\" mean the channel can be used normally"
+              "The channel state, in particular \"CHANNELD_NORMAL\" and \"CHANNELD_AWAITING_SPLICE\" mean the channel can be used normally",
+              "Note: *CLOSED* state was only added in v25.12."
             ],
             "added": "pre-v0.10.1"
           },
diff --git a/doc/schemas/notification/channel_state_changed.json b/doc/schemas/notification/channel_state_changed.json
index 72e470d2..c2f1aba1 100644
--- a/doc/schemas/notification/channel_state_changed.json
+++ b/doc/schemas/notification/channel_state_changed.json
@@ -87,10 +87,12 @@
           "DUALOPEND_AWAITING_LOCKIN",
           "CHANNELD_AWAITING_SPLICE",
           "DUALOPEND_OPEN_COMMITTED",
-          "DUALOPEND_OPEN_COMMIT_READY"
+          "DUALOPEND_OPEN_COMMIT_READY",
+          "CLOSED"
         ],
         "description": [
-          "The channel state, in particular \"CHANNELD_NORMAL\" and \"CHANNELD_AWAITING_SPLICE\" mean the channel can be used normally"
+          "The channel state, in particular \"CHANNELD_NORMAL\" and \"CHANNELD_AWAITING_SPLICE\" mean the channel can be used normally",
+          "Note: *CLOSED* state was only added in v25.12."
         ],
         "added": "pre-v0.10.1"
       },

Risk score

Why this scored 18/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 5/15

Confidence 9/10

Evidence quality 4/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 18/100

Community notes

Related watches

Revert "doc: require Homebrew GNU make and gpatch on macOS"

Revert "tests: drop obsolete x-prefix in compacter-slow.sh"

doc: require Homebrew GNU make and gpatch on macOS