pyln-testing: don't run reckless under valgrind.
What the developer wrote
Authored by Rusty Russell
pyln-testing: don't run reckless under valgrind.
We can timeout if we do (it's Python). Unfortunately I didn't catch
the flake.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This is a one-line testing infrastructure change. It adds a 'reckless' binary to a list of programs that should be skipped when running tests under the Valgrind memory-checking tool. The change prevents test timeouts caused by Valgrind slowing down a Python-based helper called reckless. There is no security vulnerability or user-facing bug fix here.
No security action needed. Treat as a normal test-hardening commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In contrib/pyln-testing/pyln/testing/utils.py, the LightningNode setup expands the Valgrind trace_skip_pattern to include ‘*reckless’. This tells Valgrind not to instrument the reckless helper during functional tests, avoiding timeouts. It is a test-framework reliability tweak, not a patch for a security issue in Core Lightning itself.
Changed components
contrib/pyln-testing/pyln/testing/utils.pyInspect captured patch +1 / −1
diff --git a/contrib/pyln-testing/pyln/testing/utils.py b/contrib/pyln-testing/pyln/testing/utils.py
index 3f663e2b..caa03513 100644
--- a/contrib/pyln-testing/pyln/testing/utils.py
+++ b/contrib/pyln-testing/pyln/testing/utils.py
@@ -859,7 +859,7 @@ class LightningNode(object):
if dsn is not None:
self.daemon.opts['wallet'] = dsn
if valgrind:
- trace_skip_pattern = '*python*,*bitcoin-cli*,*elements-cli*,*cln-grpc*,*clnrest*,*wss-proxy*,*cln-bip353*'
+ trace_skip_pattern = '*python*,*bitcoin-cli*,*elements-cli*,*cln-grpc*,*clnrest*,*wss-proxy*,*cln-bip353*,*reckless'
if not valgrind_plugins:
trace_skip_pattern += ',*plugins*'
self.daemon.cmd_prefix = [
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.