pytest: don't run test_hook_in_use under VALGRIND on CI.
What the developer wrote
Authored by Rusty Russell
pytest: don't run test_hook_in_use under VALGRIND on CI.
It's not reliable:
```
# We should have deferred hook update at least once!
> l2.daemon.wait_for_log("UNUSUAL plugin-dep_b.py: Deferring registration of hook htlc_accepted until it's not in use.")
tests/test_plugin.py:2646:
...
if self.is_in_log(r):
print("({} was previously in logs!)".format(r))
> raise TimeoutError('Unable to find "{}" in logs.'.format(exs))
E TimeoutError: Unable to find "[re.compile("UNUSUAL plugin-dep_b.py: Deferring registration of hook htlc_accepted until it's not in use.")]" in logs.
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit only changes a test file. It marks one flaky test so it does not run under the VALGRIND memory-checking tool in CI. There is no change to production code, no security fix, and no vulnerability.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds @pytest.mark.slow_test to test_hook_in_use in tests/test_plugin.py because the test’s expected log line about deferred hook registration is not reliably produced when running under VALGRIND due to timing/race conditions. This is a CI/test reliability tweak only.
Changed components
tests/test_plugin.pyInspect captured patch +1 / −0
diff --git a/tests/test_plugin.py b/tests/test_plugin.py
index d63d1867..713b3fbb 100644
--- a/tests/test_plugin.py
+++ b/tests/test_plugin.py
@@ -2614,6 +2614,7 @@ def test_htlc_accepted_hook_failonion(node_factory):
l1.rpc.pay(inv)
+@pytest.mark.slow_test # VALGRIND running generally too slow to trigger race we need.
def test_hook_in_use(node_factory):
"""If a hook is in use when we add a plugin to it, we have to defer"""
dep_a = os.path.join(os.path.dirname(__file__), 'plugins/dep_a.py')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.