Informational 15 Bitcoin Committed Oct 28, 2025 · 00:33 UTC

GitHub: add --durations=10 to pytest runs.

4f9e13c0 View source ↗

Public commit record

What the developer wrote

Authored by Rusty Russell

78/100 · Adequate

GitHub: add --durations=10 to pytest runs.

This allows us to show what tests are slowest, by showing the duration for anything
which took 10 seconds or longer.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification

The short version

What changed, and why it matters

This commit only adds a pytest command-line option that prints how long each slow test took. It does not change any application code, security settings, or test behavior. There is no security relevance.

Recommended action

No action required. The change is a benign CI observability improvement.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The commit appends --durations=10 to PYTEST_OPTS in six GitHub Actions CI workflow jobs. This pytest flag causes the test runner to list tests that took 10 seconds or longer after the run completes. It is a reporting/observability change only; it does not alter test selection, timeouts, compilation flags, network configuration, or any Core Lightning source code.

Changed components

.github/workflows/ci.yaml

Inspect captured patch +6 / −6

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 78fc45ad..31c1e70c 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -89,7 +89,7 @@ jobs:
       - name: Check source
         env:
           VALGRIND: 0
-          PYTEST_OPTS: --timeout=1200
+          PYTEST_OPTS: --timeout=1200 --durations=10
         run: |
           uv run make check-source BASE_REF="origin/${{ github.base_ref }}"
       - name: Check Generated Files have been updated
@@ -241,7 +241,7 @@ jobs:
     timeout-minutes: 120
     env:
       RUST_PROFILE: release # Has to match the one in the compile step
-      PYTEST_OPTS: --timeout=1200
+      PYTEST_OPTS: --timeout=1200 --durations=10
     needs:
       - compile
     strategy:
@@ -350,7 +350,7 @@ jobs:
     env:
       RUST_PROFILE: release # Has to match the one in the compile step
       CFG: compile-gcc
-      PYTEST_OPTS: --test-group-random-seed=42 --timeout=1800
+      PYTEST_OPTS: --test-group-random-seed=42 --timeout=1800 --durations=10
     needs:
       - compile
     strategy:
@@ -421,7 +421,7 @@ jobs:
       RUST_PROFILE: release
       SLOW_MACHINE: 1
       TEST_DEBUG: 1
-      PYTEST_OPTS: --test-group-random-seed=42 --timeout=1800
+      PYTEST_OPTS: --test-group-random-seed=42 --timeout=1800 --durations=10
     needs:
       - compile
     strategy:
@@ -489,7 +489,7 @@ jobs:
     env:
       VALGRIND: 0
       GENERATE_EXAMPLES: 1
-      PYTEST_OPTS: --timeout=1200
+      PYTEST_OPTS: --timeout=1200 --durations=10
       TEST_NETWORK: regtest
     needs:
       - compile
@@ -528,7 +528,7 @@ jobs:
     timeout-minutes: 120
     env:
       RUST_PROFILE: release # Has to match the one in the compile step
-      PYTEST_OPTS: --timeout=1200
+      PYTEST_OPTS: --timeout=1200 --durations=10
     needs:
       - compile
     strategy:

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

Revert "doc: require Homebrew GNU make and gpatch on macOS"

Revert "tests: drop obsolete x-prefix in compacter-slow.sh"

doc: require Homebrew GNU make and gpatch on macOS