pytest: fix flae int test_fetchinvoice_autoconnect.
What the developer wrote
Authored by Rusty Russell
pytest: fix flae int test_fetchinvoice_autoconnect.
l3 doesn't just need to know about l2 (which it can get from the
channel_announcement), but needs to see the node_announcement.
Otherwise:
```
l1, l2 = node_factory.line_graph(2, wait_for_announce=True,
# No onion_message support in l1
opts=[{'dev-force-features': -39},
{'dev-allow-localhost': None}])
l3 = node_factory.get_node()
l3.rpc.connect(l1.info['id'], 'localhost', l1.port)
wait_for(lambda: l3.rpc.listnodes(l2.info['id'])['nodes'] != [])
offer = l2.rpc.call('offer', {'amount': '2msat',
'description': 'simple test'})
> l3.rpc.call('fetchinvoice', {'offer': offer['bolt12']})
tests/test_pay.py:4804:
...
> raise RpcError(method, payload, resp['error'])
E pyln.client.lightning.RpcError: RPC call failed: method: fetchinvoice, payload: {'offer': 'lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqypq5zmnd9khqmr9yp6x2um5zcssxwz9sqkjtd8qwnx06lxckvu6g8w8t0ue0zsrfqqygj636s4sw7v6'}, error: {'code': 1003, 'message': 'Failed: could not route or connect directly to 033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a: {"code":400,"message":"Unable to connect, no address known for peer"}'}
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit fixes a flaky test in the Core Lightning test suite. The test was waiting until a node learned about another node's existence, but it actually needed to wait until it also learned the node's network address. No production code was changed, and there is no security issue.
No security action required. This is a routine test flake fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is in tests/test_pay.py in test_fetchinvoice_autoconnect. The wait_for condition is tightened from merely checking that listnodes returns a non-empty list for l2, to checking that the returned node entries include ‘addresses’. This ensures l3 has received l2’s node_announcement (which carries addresses) before fetchinvoice is called, preventing a routing failure due to missing peer address. It is a test-only reliability fix.
Changed components
tests/test_pay.py::test_fetchinvoice_autoconnectInspect captured patch +1 / −1
diff --git a/tests/test_pay.py b/tests/test_pay.py
index 5ab969af..1f31762c 100644
--- a/tests/test_pay.py
+++ b/tests/test_pay.py
@@ -4797,7 +4797,7 @@ def test_fetchinvoice_autoconnect(node_factory, bitcoind):
l3 = node_factory.get_node()
l3.rpc.connect(l1.info['id'], 'localhost', l1.port)
- wait_for(lambda: l3.rpc.listnodes(l2.info['id'])['nodes'] != [])
+ wait_for(lambda: ['addresses' in n for n in l3.rpc.listnodes(l2.info['id'])['nodes']] == [True])
offer = l2.rpc.call('offer', {'amount': '2msat',
'description': 'simple test'})
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.