common: fix run-mkdatastorekey link on arm64
What the developer wrote
Authored by Sangbida Chaudhuri
common: fix run-mkdatastorekey link on arm64
Add common/pseudorand.o to its link line to fix below error seen on CI:
Undefined symbols for architecture arm64:
"_siphash_seed", referenced from:
_script_with_len_hash in script.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [common/test/run-mkdatastorekey] Error 1
What changed, and why it matters
This is a routine build fix for a test program on ARM64 computers. A missing piece (a file called pseudorand.o) was added to the linker command so the test binary compiles successfully. It does not change how the software behaves or fix any security flaw.
No security action needed; treat as a normal build fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit adds common/pseudorand.o to the link line for common/test/run-mkdatastorekey in common/test/Makefile. The test binary uses script.o, which references siphash_seed defined in common/pseudorand.o. On arm64 CI the linker failed because that object was not included. This is a build-system dependency correction with no runtime or security implications.
Changed components
common/test/MakefileInspect captured patch +3 / −0
diff --git a/common/test/Makefile b/common/test/Makefile
index 988ef151..b1b63de5 100644
--- a/common/test/Makefile
+++ b/common/test/Makefile
@@ -126,6 +126,9 @@ common/test/run-trace: \
wire/fromwire.o \
wire/towire.o
+common/test/run-mkdatastorekey: \
+ common/pseudorand.o
+
common/test/run-htable: \
common/pseudorand.o
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.