AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 32 Bitcoin

tools: update hsmtool to use the new hsm_secret API.

Public commit record

What the developer wrote

Authored by Sangbida Chaudhuri

73/100 · Adequate
tools: update hsmtool to use the new hsm_secret API.

Changelog-Added: `hsmtool` now supports hsm_secret files using a 12-word mnemonic.
Changelog-Removed: hsmtool support for mnemonics in non-english languages removed.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit refactors the Core Lightning 'hsmtool' utility to use a new unified API for handling the node's master secret file (hsm_secret). It adds support for storing the secret as a 12-word English mnemonic phrase inside the file, and removes support for non-English mnemonic wordlists. The change is a feature/rewrite rather than a clear security fix, but it touches sensitive key-handling code and removes some legacy behavior. There is no vendor statement that this is a security patch, and no independent attribution.

Recommended action

Review the new hsm_secret API implementation (not fully shown in this diff) for correct passphrase handling, memory zeroization, and file permissions. Verify that storing the mnemonic in the hsm_secret file is an intentional design choice and that the seed hash comparison does not introduce false positives/negatives. Re-enable the skipped expose-secrets test once the unrelated issue is resolved. Treat as a normal feature commit unless additional context shows it fixes a disclosed vulnerability.

Security signals we found

01

Refactor of secret-key handling utility

02

New mnemonic storage format stores seed hash plus cleartext mnemonic in hsm_secret file

03

Removal of non-English BIP39 language support reduces attack surface but may break existing workflows

04

Legacy encrypt/decrypt commands now explicitly reject mnemonic-format files

05

Temporary skip of test_exposesecret (reason unrelated to patch content)

06

No explicit security bug fix or CVE reference in commit message

Risk score

Why this scored 32/100

Our methodology →
Potential impact 8/30
Exploitability 6/25
Stealth signal 4/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.