← Watch feed
pytest: test coinmoves in the case of unexpected fulfill.
Public commit record
88/100 · Strong
What the developer wrote
Authored by Rusty Russell
pytest: test coinmoves in the case of unexpected fulfill.
This happens if l1 doesn't get a signature, so it doesn't consider
the fulfill complete, but l2 does (and thus credits l1).
This is a trivial test, but will matter should we later correctly
account for channelmoves when onchain: in that case it will actually
hard to tell, in general, what HTLC(s) were fulfilled.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
What changed, and why it matters
This commit only adds a new test case to the project's test suite. It simulates a scenario where one side of a Lightning payment channel believes an HTLC was fulfilled while the other side does not, then verifies that the internal accounting records (called 'coinmoves') are produced correctly. There is no change to production code, no fix, and no vulnerability being patched.
Recommended action
No security action required. This is a test-only addition. Reviewers may optionally run the new test to confirm it passes and that the documented coinmove expectations match current behavior.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds a single pytest function, test_coinmoves_unilateral_htlc_fulfilled_oneside, to tests/test_coinmoves.py. The test constructs a regtest scenario where l1 drops to chain after sending an HTLC but does not receive (or process) the WIRE_COMMITMENT_SIGNED messages, so l1 does not consider the fulfill complete while l2 does. It then asserts the expected coinmove/accounting entries for both nodes through channel close, anchor spends, delayed output resolution, and final peer cleanup. No source code outside the test file is modified.
Changed components
tests/test_coinmoves.pyInspect captured patch +216 / −0
diff --git a/tests/test_coinmoves.py b/tests/test_coinmoves.py
index 1492504..78f0610 100644
--- a/tests/test_coinmoves.py
+++ b/tests/test_coinmoves.py
@@ -1401,6 +1401,222 @@ def test_coinmoves_unilateral_htlc_fulfill(node_factory, bitcoind):
# We send an HTLC, but it's not accounted in channel.
check_balances(l1, l2, fundchannel['channel_id'], 0)
+
+@pytest.mark.openchannel('v1')
+@pytest.mark.openchannel('v2')
+@unittest.skipIf(TEST_NETWORK != 'regtest', "Amounts are for regtest.")
+def test_coinmoves_unilateral_htlc_fulfilled_oneside(node_factory, bitcoind):
+ """l1 drops to chain with HTLC fulfilled (included in l2's output), l2 hasn't seen completion yet."""
+ if EXPERIMENTAL_DUAL_FUND:
+ disc = ['-WIRE_COMMITMENT_SIGNED*5']
+ else:
+ disc = ['-WIRE_COMMITMENT_SIGNED*4']
+ l1, l2 = node_factory.get_nodes(2, opts=[{'disconnect': disc}, {}])
+
+ expected_channel1, expected_channel2, expected_chain1, expected_chain2, fundchannel = setup_channel(bitcoind, l1, l2)
+
+ inv = l2.rpc.invoice('any', 'test_coinmoves_unilateral_htlc_fulfilled_oneside', 'test_coinmoves_unilateral_htlc_fulfilled_oneside')
+ routestep = {
+ # We will spend anchor to make this confirm.
+ 'amount_msat': 100000000,
+ 'id': l2.info['id'],
+ 'delay': 10,
+ 'channel': l1.get_channel_scid(l2),
+ }
+ l1.rpc.sendpay([routestep], inv['payment_hash'], payment_secret=inv['payment_secret'], bolt11=inv['bolt11'])
+ wait_for(lambda: only_one(l1.rpc.listpeers(l2.info['id'])['peers'])['connected'] is False)
+
+ check_channel_moves(l1, expected_channel1)
+ check_channel_moves(l2, expected_channel2)
+ check_chain_moves(l1, expected_chain1)
+ check_chain_moves(l2, expected_chain2)
+
+ close_info = l1.rpc.close(l2.info['id'], unilateraltimeout=1)
+
+ # We will spend anchor to confirm this.
+ line = l1.daemon.wait_for_log("Creating anchor spend for local commit tx ")
+ anchor_spend_txid = re.search(r'Creating anchor spend for local commit tx ([0-9a-f]{64})', line).group(1)
+
+ bitcoind.generate_block(1, wait_for_mempool=2)
+ sync_blockheight(bitcoind, [l1, l2])
+
+ # Make sure onchaind has digested it.
+ l2.daemon.wait_for_log('All outputs resolved: waiting 100 more blocks before forgetting channel')
+ l1.daemon.wait_for_log('5 outputs unresolved: in 5 blocks will spend DELAYED_OUTPUT_TO_US')
+
+ # Which outputs are anchors, and which are to us and which to them?
+ # Use onchaind's logs, eg:
+ # Tracking output 0e1cfbc2be0aada02222a163a1a413fd0b06bae8017c3626cbf8816499dadc09:0: OUR_UNILATERAL/ANCHOR_TO_THEM
+ line = l1.daemon.is_in_log('Tracking output.*/ANCHOR_TO_THEM')
+ anch_to_l2 = int(re.search(r'output [0-9a-f]{64}:([0-9]):', line).group(1))
+ line = l1.daemon.is_in_log('Tracking output.*/ANCHOR_TO_US')
+ anch_to_l1 = int(re.search(r'output [0-9a-f]{64}:([0-9]):', line).group(1))
+ line = l1.daemon.is_in_log('Tracking output.*/DELAYED_OUTPUT_TO_US')
+ to_l1 = int(re.search(r'output [0-9a-f]{64}:([0-9]):', line).group(1))
+ line = l1.daemon.is_in_log('Tracking output.*/OUTPUT_TO_THEM')
+ to_l2 = int(re.search(r'output [0-9a-f]{64}:([0-9]):', line).group(1))
+
+ expected_chain1 += [{'account_id': 'wallet', # Anchor spend from fundchannel change
+ 'blockheight': 104,
+ 'credit_msat': 0,
+ 'debit_msat': 25000000,
+ 'extra_tags': [],
+ 'output_msat': 25000000,
+ 'primary_tag': 'withdrawal',
+ 'spending_txid': anchor_spend_txid,
+ 'utxo': f"{fundchannel['txid']}:{fundchannel['outnum'] ^ 1}"},
+ {'account_id': 'wallet', # Change from anchor spend
+ 'blockheight': 104,
+ 'credit_msat': 16186000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'output_msat': 16186000,
+ 'primary_tag': 'deposit',
+ 'utxo': f"{anchor_spend_txid}:0"},
+ {'account_id': fundchannel['channel_id'],
+ 'blockheight': 104,
+ 'credit_msat': 0,
+ 'debit_msat': 99970073000 - 50000000000,
+ 'extra_tags': [],
+ 'output_count': 4,
+ 'output_msat': 99970073000,
+ 'primary_tag': 'channel_close',
+ 'spending_txid': only_one(close_info['txids']),
+ 'utxo': f"{fundchannel['txid']}:{fundchannel['outnum']}"},
+ {'account_id': 'external',
+ 'blockheight': 104,
+ 'credit_msat': 330000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 330000,
+ 'primary_tag': 'anchor',
+ 'utxo': f"{only_one(close_info['txids'])}:{anch_to_l2}"},
+ {'account_id': 'external',
+ 'blockheight': 104,
+ 'credit_msat': 330000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 330000,
+ 'primary_tag': 'anchor',
+ 'utxo': f"{only_one(close_info['txids'])}:{anch_to_l1}"},
+ {'account_id': 'external',
+ 'blockheight': 104,
+ 'credit_msat': 50100000000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 50100000000,
+ 'primary_tag': 'to_them',
+ 'utxo': f"{only_one(close_info['txids'])}:{to_l2}"}]
+ expected_chain2 += [{'account_id': fundchannel['channel_id'],
+ 'blockheight': 104,
+ 'credit_msat': 0,
+ 'debit_msat': 50000000000,
+ 'extra_tags': [],
+ 'output_count': 4,
+ 'output_msat': 99970073000,
+ 'primary_tag': 'channel_close',
+ 'spending_txid': only_one(close_info['txids']),
+ 'utxo': f"{fundchannel['txid']}:{fundchannel['outnum']}"},
+ {'account_id': 'external',
+ 'blockheight': 104,
+ 'credit_msat': 330000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 330000,
+ 'primary_tag': 'anchor',
+ 'utxo': f"{only_one(close_info['txids'])}:{anch_to_l2}"},
+ {'account_id': 'external',
+ 'blockheight': 104,
+ 'credit_msat': 330000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 330000,
+ 'primary_tag': 'anchor',
+ 'utxo': f"{only_one(close_info['txids'])}:{anch_to_l1}"},
+ {'account_id': 'external',
+ 'blockheight': 104,
+ 'credit_msat': 49865193000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 49865193000,
+ 'primary_tag': 'to_them',
+ 'utxo': f"{only_one(close_info['txids'])}:{to_l1}"},
+ {'account_id': 'wallet',
+ 'blockheight': 104,
+ 'credit_msat': 50100000000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'originating_account': fundchannel['channel_id'],
+ 'output_msat': 50100000000,
+ 'primary_tag': 'deposit',
+ 'utxo': f"{only_one(close_info['txids'])}:{to_l2}"}]
+ check_channel_moves(l1, expected_channel1)
+ check_chain_moves(l1, expected_chain1)
+ check_channel_moves(l2, expected_channel2)
+ check_chain_moves(l2, expected_chain2)
+
+ bitcoind.generate_block(4)
+ l1.daemon.wait_for_log('waiting confirmation that we spent DELAYED_OUTPUT_TO_US')
+ check_channel_moves(l1, expected_channel1)
+ check_chain_moves(l1, expected_chain1)
+ check_channel_moves(l2, expected_channel2)
+ check_chain_moves(l2, expected_chain2)
+
+ bitcoind.generate_block(1, wait_for_mempool=1)
+ line = l1.daemon.wait_for_log('Resolved OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by our proposal OUR_DELAYED_RETURN_TO_WALLET')
+ to_l1_txid = re.search(r'by our proposal OUR_DELAYED_RETURN_TO_WALLET \(([0-9a-f]{64})\)', line).group(1)
+
+ expected_chain1 += [{'account_id': 'wallet',
+ 'blockheight': 109,
+ 'credit_msat': 49865059000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'output_msat': 49865059000,
+ 'primary_tag': 'deposit',
+ 'utxo': f"{to_l1_txid}:0"},
+ {'account_id': fundchannel['channel_id'],
+ 'blockheight': 104,
+ 'credit_msat': 49865193000,
+ 'debit_msat': 0,
+ 'extra_tags': [],
+ 'output_msat': 49865193000,
+ 'primary_tag': 'delayed_to_us',
+ 'utxo': f"{only_one(close_info['txids'])}:{to_l1}"},
+ {'account_id': fundchannel['channel_id'],
+ 'blockheight': 109,
+ 'credit_msat': 0,
+ 'debit_msat': 49865193000,
+ 'extra_tags': [],
+ 'output_msat': 49865193000,
+ 'primary_tag': 'to_wallet',
+ 'spending_txid': to_l1_txid,
+ 'utxo': f"{only_one(close_info['txids'])}:{to_l1}"}]
+ check_channel_moves(l1, expected_channel1)
+ check_chain_moves(l1, expected_chain1)
+ check_channel_moves(l2, expected_channel2)
+ check_chain_moves(l2, expected_chain2)
+ l1.daemon.wait_for_log('All outputs resolved: waiting 100 more blocks before forgetting channel')
+
+ # Make sure it's stable!
+ bitcoind.generate_block(100)
+ sync_blockheight(bitcoind, [l1, l2])
+ time.sleep(5)
+ check_channel_moves(l1, expected_channel1)
+ check_chain_moves(l1, expected_chain1)
+ check_channel_moves(l2, expected_channel2)
+ check_chain_moves(l2, expected_chain2)
+ l1.daemon.wait_for_log('onchaind complete, forgetting peer')
+ l2.daemon.wait_for_log('onchaind complete, forgetting peer')
+
+ # We send no in-channel HTLCs
+ check_balances(l1, l2, fundchannel['channel_id'], 0)
+
# FIXME:
# MVT_PENALTY,
# MVT_PENALIZED,
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.