What the developer wrote
Authored by enaples
pytest: removed old test
What changed, and why it matters
This commit simply deletes an old test from the test suite. It removes a pytest function that checked how the software handles opening a dual-funded channel when Bitcoin fee estimates are unavailable. There is no change to the actual software code that users run, and nothing in the commit message or diff suggests a security fix or vulnerability.
No security action needed. This is a routine test-suite cleanup. If the test was removed because the underlying dual-funding behavior changed, ensure the new behavior is covered by other tests.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff removes test_opening_dualfund_with_unknown_feerates from tests/test_opening.py. The test used dev-only options (dev-no-fake-fees, ignore-fee-limits, experimental-dual-fund) to simulate a regtest environment with no fee estimates and then attempted a dual-funded channel open. No production code is modified, no bug is fixed, and no security relevance is stated.
Changed components
tests/test_opening.pyInspect captured patch +0 / −29
diff --git a/tests/test_opening.py b/tests/test_opening.py
index fc7d406a..13863df4 100644
--- a/tests/test_opening.py
+++ b/tests/test_opening.py
@@ -13,35 +13,6 @@ import unittest
import time
-@pytest.mark.xfail(strict=True)
-@unittest.skipIf(TEST_NETWORK != 'regtest', "requires regtest")
-def test_opening_dualfund_with_unknown_feerates(node_factory, bitcoind):
- """
- Test dualfund openchannel when feerates are unknown (like on signet/testnet with empty mempool).
- """
- opts = {
- 'ignore-fee-limits': True,
- 'feerates': None,
- 'dev-no-fake-fees': True,
- 'experimental-dual-fund': None
- }
-
- l1, l2 = node_factory.get_nodes(2, opts=opts)
-
- l1.fundwallet(FUNDAMOUNT)
-
- # Connect peers
- l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
-
- # Verify fee estimation is failing
- l1.daemon.wait_for_log('Unable to estimate any fees')
- l2.daemon.wait_for_log('Unable to estimate any fees')
-
- # Open channel l1 <-> l2
- l1.rpc.fundchannel(l2.info['id'], 100000, feerate='253perkw', minconf=0)['txid']
- l2.rpc.listpeerchannels(l1.info['id'])['channels']
-
-
def find_next_feerate(node, peer):
chan = only_one(node.rpc.listpeerchannels(peer.info['id'])['channels'])
return chan['next_feerate']
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.