CI: remove reruns on all failures.
What changed, and why it matters
This commit changes the project's automated testing configuration to stop automatically re-running tests that fail. Previously, every failed test was retried up to 10 times, which can hide flaky real bugs. The change itself does not alter any shipped software, network protocol, or user-facing behavior, and it does not fix or introduce a security vulnerability in the product.
No security action required. Treat as a normal CI hygiene change. Monitor subsequent CI runs for newly surfaced test failures that may reveal latent bugs.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes the pytest-rerunfailures --reruns=10 flag from PYTEST_OPTS_BASE and PYTEST_OPTS across multiple GitHub Actions CI jobs in .github/workflows/ci.yaml. The commit message explicitly states the intent: reruns were covering up real bugs and the CI process needs to be fixed instead. No application code, cryptographic logic, RPC handling, or network behavior is modified.
Changed components
.github/workflows/ci.yamlInspect captured patch +6 / −6
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index ea79a16d..2c7a9b9c 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -16,7 +16,7 @@ env:
RUST_PROFILE: release
SLOW_MACHINE: 1
CI_SERVER_URL: "http://35.239.136.52:3170"
- PYTEST_OPTS_BASE: "--reruns=10 -vvv --junit-xml=report.xml --timeout=1800 --durations=10"
+ PYTEST_OPTS_BASE: "-vvv --junit-xml=report.xml --timeout=1800 --durations=10"
jobs:
prebuild:
@@ -337,7 +337,7 @@ jobs:
timeout-minutes: 120
env:
RUST_PROFILE: release # Has to match the one in the compile step
- PYTEST_OPTS: --reruns=10 -vvv --junit-xml=report.xml --timeout=1800 --durations=10
+ PYTEST_OPTS: -vvv --junit-xml=report.xml --timeout=1800 --durations=10
needs:
- compile
strategy:
@@ -453,7 +453,7 @@ jobs:
env:
RUST_PROFILE: release # Has to match the one in the compile step
CFG: compile-gcc
- PYTEST_OPTS: --reruns=10 -vvv --junit-xml=report.xml --timeout=1800 --durations=10 --test-group-random-seed=42
+ PYTEST_OPTS: -vvv --junit-xml=report.xml --timeout=1800 --durations=10 --test-group-random-seed=42
needs:
- compile
strategy:
@@ -541,7 +541,7 @@ jobs:
RUST_PROFILE: release
SLOW_MACHINE: 1
TEST_DEBUG: 1
- PYTEST_OPTS: --reruns=10 -vvv --junit-xml=report.xml --timeout=1800 --durations=10 --test-group-random-seed=42
+ PYTEST_OPTS: -vvv --junit-xml=report.xml --timeout=1800 --durations=10 --test-group-random-seed=42
needs:
- compile
strategy:
@@ -632,7 +632,7 @@ jobs:
env:
VALGRIND: 0
GENERATE_EXAMPLES: 1
- PYTEST_OPTS: --reruns=10 -vvv --junit-xml=report.xml --timeout=1800 --durations=10
+ PYTEST_OPTS: -vvv --junit-xml=report.xml --timeout=1800 --durations=10
TEST_NETWORK: regtest
needs:
- compile
@@ -678,7 +678,7 @@ jobs:
timeout-minutes: 120
env:
RUST_PROFILE: release # Has to match the one in the compile step
- PYTEST_OPTS: --reruns=10 -vvv --junit-xml=report.xml --timeout=1800 --durations=10
+ PYTEST_OPTS: -vvv --junit-xml=report.xml --timeout=1800 --durations=10
needs:
- compile
strategy:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.